Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10000013: Update to current version of the SpiderMonkey shell, adjust for thedifferent handling of for loops… (Closed)

Created:
April 3, 2013, 11:24 a.m. by Wladimir Palant
Modified:
April 3, 2013, 1:47 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Update to current version of the SpiderMonkey shell, adjust for the different handling of for loops and -U command line parameter being no longer necessary.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M abp_rewrite.py View 1 chunk +1 line, -1 line 0 comments Download
M autotest.py View 1 chunk +1 line, -1 line 0 comments Download
M autotest/abprewrite_source.js View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/abprewrite.js View 1 chunk +31 lines, -0 lines 0 comments Download
M utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Wladimir Palant
April 3, 2013, 11:24 a.m. (2013-04-03 11:24:12 UTC) #1
Felix Dahlke
LGTM, although I'm wondering if we shouldn't just include jsshell with jshydra so we don't ...
April 3, 2013, 12:53 p.m. (2013-04-03 12:53:18 UTC) #2
Wladimir Palant
April 3, 2013, 1:47 p.m. (2013-04-03 13:47:12 UTC) #3
On 2013/04/03 12:53:18, Felix H. Dahlke wrote:
> LGTM, although I'm wondering if we shouldn't just include jsshell with jshydra
> so we don't run into this problem again in a while.

Which jsshell - Windows, OS X or Linux (two of them)? :)
The original idea was that we would normally use the latest code. We merely
didn't because of my laziness.

Powered by Google App Engine
This is Rietveld