Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10187046: Rationalize preprocessor guard variable names (Closed)

Created:
April 29, 2013, 9:33 p.m. by Eric
Modified:
April 30, 2013, 7:10 a.m.
Visibility:
Public.

Description

Guard variable change

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M include/AdblockPlus.h View 1 chunk +2 lines, -2 lines 1 comment Download
M include/AdblockPlus/DefaultErrorCallback.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/AdblockPlus/DefaultFileSystem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/AdblockPlus/DefaultWebRequest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/AdblockPlus/ErrorCallback.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/AdblockPlus/FileSystem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/AdblockPlus/FilterEngine.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/AdblockPlus/JsEngine.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/AdblockPlus/JsValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/AdblockPlus/WebRequest.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Eric
April 29, 2013, 9:35 p.m. (2013-04-29 21:35:30 UTC) #1
Felix Dahlke
LGTM with the one issue fixed http://codereview.adblockplus.org/10187046/diff/1/include/AdblockPlus.h File include/AdblockPlus.h (right): http://codereview.adblockplus.org/10187046/diff/1/include/AdblockPlus.h#newcode1 include/AdblockPlus.h:1: #ifndef ADBLOCK_PLUS_ADBLOCKPLUS_H Should ...
April 30, 2013, 3:11 a.m. (2013-04-30 03:11:42 UTC) #2
Wladimir Palant
April 30, 2013, 5:55 a.m. (2013-04-30 05:55:05 UTC) #3
LGTM with Felix' comment addressed.

Powered by Google App Engine
This is Rietveld