Use our own isolate instead of the default one

include/AdblockPlus/JsEngine.h

 #ifndef ADBLOCKPLUS_JS_ENGINE_H
 #define ADBLOCKPLUS_JS_ENGINE_H
 
 #include <stdexcept>
 #include <string>
 #include <v8.h>
 #include <AdblockPlus/JsValue.h>
 
 namespace AdblockPlus
 {
@@ skipping 41 matching lines @@
     }
     inline WebRequest& GetWebRequest()
     {
       return webRequest;
     }
     inline ErrorCallback& GetErrorCallback()
     {
       return errorCallback;
     }
 
+    class IsolateSetter

[Felix Dahlke, 2013/04/18 12:16:11]

Not entirely happy with IsolateSetter as a name, but struggling to come up with
anything better. IsolateEnterer? IsolateScope? Not brilliant either.

+    {
+    public:
+      IsolateSetter(v8::Isolate* isolate);
+      virtual ~IsolateSetter();

[Felix Dahlke, 2013/04/18 12:16:11]

Since this is not a base class, the destructor shouldn't be virtual.

+
+    private:
+      v8::Isolate* isolate;
+    };
+
     class Context
     {
     public:
       Context(const JsEngine& jsEngine);
-      virtual inline ~Context() {};
+      virtual ~Context() {}

[Felix Dahlke, 2013/04/18 12:16:11]

Since Context is not being inherited from what I see, it doesn't need a virtual
destructor.

 
     private:
       const v8::Locker locker;
+      const IsolateSetter isolateSetter;
       const v8::HandleScope handleScope;
       const v8::Context::Scope contextScope;
     };
 
   private:
     FileSystem& fileSystem;
     WebRequest& webRequest;
     ErrorCallback& errorCallback;
     v8::Isolate* isolate;
     v8::Persistent<v8::Context> context;
   };
 }
 
 #endif