Issue 10190024: Use our own isolate instead of the default one

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10190024: Use our own isolate instead of the default one (Closed)

Created:
April 17, 2013, 1:40 p.m. by Wladimir Palant

Modified:
May 22, 2013, 2:41 p.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

Not sure whether this is actually worth committing.

Patch Set 1 : #

Total comments: 3

Created: April 17, 2013, 1:44 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -3 lines)			Patch
M	include/AdblockPlus/JsEngine.h	View	1 chunk	+12 lines, -1 line	3 comments	Download
M	src/JsEngine.cpp	View	3 chunks	+14 lines, -2 lines	0 comments	Download
M	src/JsValue.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Felix Dahlke

LGTM with the nit fixed. http://codereview.adblockplus.org/10190024/diff/2001/include/AdblockPlus/JsEngine.h File include/AdblockPlus/JsEngine.h (right): http://codereview.adblockplus.org/10190024/diff/2001/include/AdblockPlus/JsEngine.h#newcode62 include/AdblockPlus/JsEngine.h:62: class IsolateSetter Not entirely ...

April 18, 2013, 12:16 p.m. (2013-04-18 12:16:11 UTC) #1

Wladimir Palant

May 22, 2013, 2:41 p.m. (2013-05-22 14:41:35 UTC) #2

Seeing that we managed to move along just fine without this change - it doesn't
seem to be worth pushing.

Expand All Messages | Collapse All Messages