| Index: include/AdblockPlus/JsEngine.h |
| =================================================================== |
| --- a/include/AdblockPlus/JsEngine.h |
| +++ b/include/AdblockPlus/JsEngine.h |
| @@ -54,24 +54,35 @@ namespace AdblockPlus |
| { |
| return webRequest; |
| } |
| inline ErrorCallback& GetErrorCallback() |
| { |
| return errorCallback; |
| } |
| + class IsolateSetter |
|
Felix Dahlke
2013/04/18 12:16:11
Not entirely happy with IsolateSetter as a name, b
|
| + { |
| + public: |
| + IsolateSetter(v8::Isolate* isolate); |
| + virtual ~IsolateSetter(); |
|
Felix Dahlke
2013/04/18 12:16:11
Since this is not a base class, the destructor sho
|
| + |
| + private: |
| + v8::Isolate* isolate; |
| + }; |
| + |
| class Context |
| { |
| public: |
| Context(const JsEngine& jsEngine); |
| - virtual inline ~Context() {}; |
| + virtual ~Context() {} |
|
Felix Dahlke
2013/04/18 12:16:11
Since Context is not being inherited from what I s
|
| private: |
| const v8::Locker locker; |
| + const IsolateSetter isolateSetter; |
| const v8::HandleScope handleScope; |
| const v8::Context::Scope contextScope; |
| }; |
| private: |
| FileSystem& fileSystem; |
| WebRequest& webRequest; |
| ErrorCallback& errorCallback; |