Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/JsValue.cpp

Issue 10190024: Use our own isolate instead of the default one (Closed)
Patch Set: Created April 17, 2013, 1:44 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« include/AdblockPlus/JsEngine.h ('K') | « src/JsEngine.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/JsValue.cpp
===================================================================
--- a/src/JsValue.cpp
+++ b/src/JsValue.cpp
@@ -21,16 +21,17 @@ AdblockPlus::JsValue::JsValue(AdblockPlu
v8::Handle<v8::Value> value)
: jsEngine(jsEngine),
value(v8::Persistent<v8::Value>::New(jsEngine.isolate, value))
{
}
AdblockPlus::JsValue::~JsValue()
{
+ const JsEngine::Context context(jsEngine);
value.Dispose(jsEngine.isolate);
}
bool AdblockPlus::JsValue::IsUndefined() const
{
const JsEngine::Context context(jsEngine);
return value->IsUndefined();
}
« include/AdblockPlus/JsEngine.h ('K') | « src/JsEngine.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld