Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsEngine.h

Issue 10274013: Simplified JsEngine API, Call() and GetVariable() aren`t reallynecessary if Evaluate() returns a v… (Closed)
Patch Set: Slight improvement Created April 11, 2013, 5:44 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/JsEngine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/JsEngine.h
===================================================================
--- a/include/AdblockPlus/JsEngine.h
+++ b/include/AdblockPlus/JsEngine.h
@@ -19,22 +19,19 @@ namespace AdblockPlus
};
class JsEngine
{
public:
JsEngine(const FileReader* const fileReader,
WebRequest* const webRequest,
ErrorCallback* const errorCallback);
- std::string Evaluate(const char* source, const char* filename = NULL);
std::string Evaluate(const std::string& source,
const std::string& filename = "");
void Load(const std::string& scriptPath);
- std::string Call(const std::string& functionName);
- std::string GetVariable(const std::string& name);
void Gc();
private:
const FileReader* const fileReader;
v8::Persistent<v8::Context> context;
};
}
« no previous file with comments | « no previous file | src/JsEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld