Issue 10274013: Simplified JsEngine API, Call() and GetVariable() aren`t reallynecessary if Evaluate() returns a v…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10274013: Simplified JsEngine API, Call() and GetVariable() aren`t reallynecessary if Evaluate() returns a v… (Closed)

Created:
April 11, 2013, 4:13 p.m. by Wladimir Palant

Modified:
April 11, 2013, 5:49 p.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

This builds on a JsEngine change in http://codereview.adblockplus.org/10259001/.

Created: April 11, 2013, 5:44 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -49 lines)			Patch
M	include/AdblockPlus/JsEngine.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/JsEngine.cpp	View	1	2 chunks	+6 lines, -39 lines	0 comments	Download
M	test/GlobalJsObject.cpp	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	test/JsEngine.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4

Felix Dahlke

Nice, that's something I had on the refactoring backlog :) LGTM

April 11, 2013, 5:41 p.m. (2013-04-11 17:41:14 UTC) #2

Wladimir Palant

I noticed that I left a small inconsistency there, fixed it now.

April 11, 2013, 5:45 p.m. (2013-04-11 17:45:08 UTC) #3

Felix Dahlke

April 11, 2013, 5:48 p.m. (2013-04-11 17:48:05 UTC) #4

On 2013/04/11 17:45:08, Wladimir Palant wrote:
> I noticed that I left a small inconsistency there, fixed it now.

LGTM+1 :)