Fix errors, pass AppInfo

Shared/AdblockPlusClient.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #include "PluginFilter.h"
 #include "PluginClientFactory.h"
 #include "PluginDictionary.h"
 #include "PluginHttpRequest.h"
 #include "PluginMutex.h"
 #include "PluginClass.h"
 
 #include "AdblockPlusClient.h"
 
 
 CAdblockPlusClient* CAdblockPlusClient::s_instance = NULL;
 
 
 CAdblockPlusClient::CAdblockPlusClient() : CPluginClientBase()
 {
   m_filter = std::auto_ptr<CPluginFilter>(new CPluginFilter());
-  fileSystem = std::auto_ptr<AdblockPlus::DefaultFileSystem>(new AdblockPlus::DefaultFileSystem());
-  webRequest = std::auto_ptr<AdblockPlus::DefaultWebRequest>(new AdblockPlus::DefaultWebRequest());
-  errorCallback = std::auto_ptr<CerrErrorCallback>(new CerrErrorCallback());
-  jsEngine = std::auto_ptr<AdblockPlus::JsEngine>(new AdblockPlus::JsEngine(fileSystem.get(), webRequest.get(), errorCallback.get()));
-  filterEngine = std::auto_ptr<AdblockPlus::FilterEngine>(new AdblockPlus::FilterEngine(*jsEngine));
+  AdblockPlus::AppInfo appInfo;
+  appInfo.name = "Adblock Plus for Internet Explorer";

[Wladimir Palant, 2013/04/19 06:35:59]

This isn't a string displayed to the user - rather a code used internally
(corresponding to the basename setting of manifest.gecko, will probably be sent
to the server in filter downloads later). So it should be "adblockplusie".

+  appInfo.version = CT2CA(_T(IEPLUGIN_VERSION), CP_UTF8);
+  appInfo.platform = "Internet Explorer";

[Wladimir Palant, 2013/04/19 06:35:59]

Same here, it's not a user-visible string - rather something we use for
branching in our code. Should be "msie" I think.

+  JsEnginePtr jsEngine(AdblockPlus::JsEngine::New(appInfo));
+  filterEngine = std::auto_ptr<AdblockPlus::FilterEngine>(new AdblockPlus::FilterEngine(jsEngine));
 }
 CAdblockPlusClient::~CAdblockPlusClient()
 {
   s_instance = NULL;
 }
 
 
 CAdblockPlusClient* CAdblockPlusClient::GetInstance()
 {
   CAdblockPlusClient* instance = NULL;
@@ skipping 107 matching lines @@
   BYTE version[50];
   cbData = 50;
   status = RegQueryValueEx(hKey, L"Version", NULL, &type, (BYTE*)version, &cbData);
   if (status != 0)
   {
     return 0;
   }
   RegCloseKey(hKey);
   return (int)(version[0] - 48);
 }