Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10338036: Fix errors, pass AppInfo (Closed)

Created:
April 19, 2013, 3:11 a.m. by Felix Dahlke
Modified:
Nov. 12, 2013, 10:09 a.m.
Visibility:
Public.

Description

This was necessary to make ABP for IE build. I wanted to make app name and platform translateable, but wasn't sure how to best make the dictionary available to AdblockPlusClient. Hints appreciated :)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M AdBlocker/AdBlocker.vcxproj View 2 chunks +0 lines, -2 lines 0 comments Download
M Shared/AdblockPlusClient.h View 1 chunk +0 lines, -14 lines 0 comments Download
M Shared/AdblockPlusClient.cpp View 1 chunk +6 lines, -5 lines 2 comments Download

Messages

Total messages: 4
Felix Dahlke
April 19, 2013, 3:22 a.m. (2013-04-19 03:22:29 UTC) #1
Wladimir Palant
Making these strings translatable shouldn't be necessary :) http://codereview.adblockplus.org/10338036/diff/1/Shared/AdblockPlusClient.cpp File Shared/AdblockPlusClient.cpp (right): http://codereview.adblockplus.org/10338036/diff/1/Shared/AdblockPlusClient.cpp#newcode22 Shared/AdblockPlusClient.cpp:22: appInfo.name ...
April 19, 2013, 6:35 a.m. (2013-04-19 06:35:59 UTC) #2
Felix Dahlke
Pushed the fixes, got an informal LGTM from Wladimir.
April 29, 2013, 11:01 a.m. (2013-04-29 11:01:31 UTC) #3
Wladimir Palant
April 29, 2013, 11:31 a.m. (2013-04-29 11:31:04 UTC) #4
On 2013/04/29 11:01:31, Felix H. Dahlke wrote:
> Pushed the fixes, got an informal LGTM from Wladimir.

Formal LGTM for the changes pushed with
https://hg.adblockplus.org/adblockplusie/rev/cf402cc030d1 :)

Powered by Google App Engine
This is Rietveld