Makefile - Issue 10488022: Added Android build target

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: Makefile

Issue 10488022: Added Android build target (Closed)

Left Patch Set: Created May 16, 2013, 10:23 a.m.

Right Patch Set: Review comments addressed Created May 24, 2013, 8:40 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 ARCH := x64	1 ARCH := x64

2	2

3 ANDROID_PARAMETERS = target_arch=arm OS=android	3 ANDROID_PARAMETERS = target_arch=arm OS=android

4 ANDROID_PARAMETERS += android_target_arch=arm	4 ANDROID_PARAMETERS += android_target_arch=arm

5 ANDROID_PARAMETERS += arm_neon=0 armv7=0 arm_fpu=off vfp3=off	5 ANDROID_PARAMETERS += arm_neon=0 armv7=0 arm_fpu=off vfp3=off

6	6

7 .PHONY: all test clean v8_android android	7 .PHONY: all test clean v8_android android

8	8

9 all:	9 all:

10 third_party/gyp/gyp --depth=. -f make -I common.gypi --generator-output= build -Dtarget_arch=$(ARCH) libadblockplus.gyp	10 third_party/gyp/gyp --depth=. -f make -I common.gypi --generator-output= build -Dtarget_arch=$(ARCH) libadblockplus.gyp

11 $(MAKE) -C build	11 $(MAKE) -C build

12	12

13 test: all	13 test: all

14 build/out/Debug/tests	14 build/out/Debug/tests

15	15

16 clean:	16 clean:

17 $(RM) -r build	17 $(RM) -r build

18	18

19 v8_android:	19 v8_android:

20 » test -d third_party/v8/build/gyp \|\| mkdir third_party/v8/build/gyp	20 » mkdir -p third_party/v8/build/gyp
Wladimir Palant 2013/05/24 08:47:37 Heh, very obvious... I actually looked at man mkdi Show quoted text On 2013/05/23 13:35:44, Felix H. Dahlke wrote: > How about "mkdir -p third_party/v8/build/gyp"? Heh, very obvious... I actually looked at man mkdir before implementing it this way.
21 cp -f third_party/v8_gyp_launcher third_party/v8/build/gyp/gyp	21 cp -f third_party/v8_gyp_launcher third_party/v8/build/gyp/gyp
Felix Dahlke 2013/05/23 13:35:44 How come this is only necessary for Android? How come this is only necessary for Android? Wladimir Palant 2013/05/24 08:47:37 Normally we run our own gyp instance, we don't run Show quoted text On 2013/05/23 13:35:44, Felix H. Dahlke wrote: > How come this is only necessary for Android? Normally we run our own gyp instance, we don't run V8's make files that expect to find gyp at a fixed location.
22 DEFINES="${ANDROID_PARAMETERS}" \	22 DEFINES="${ANDROID_PARAMETERS}" \

23 OUTDIR=../../build \	23 OUTDIR=../../build \

24 $(MAKE) -C third_party/v8 android_arm.release	24 $(MAKE) -C third_party/v8 android_arm.release

25	25

26 android: v8_android	26 android: v8_android

27 GYP_DEFINES="${ANDROID_PARAMETERS}" \	27 GYP_DEFINES="${ANDROID_PARAMETERS}" \

28 third_party/gyp/gyp --depth=. -f make -I common.gypi --generator-output= build -Gandroid_ndk_version=r8e libadblockplus.gyp	28 third_party/gyp/gyp --depth=. -f make -I common.gypi --generator-output= build -Gandroid_ndk_version=r8e libadblockplus.gyp

29 ndk-build -C build installed_modules \	29 ndk-build -C build installed_modules \

30 BUILDTYPE=Release \	30 BUILDTYPE=Release \

31 APP_PLATFORM=android-9 \	31 APP_PLATFORM=android-9 \
Wladimir Palant 2013/05/16 12:06:26 This is pretty random - I simply chose it because This is pretty random - I simply chose it because V8 compiles for the android-9 platform. android-3 platform works fine as well but probably doesn't make too much sense if we use V8 code. Felix Dahlke 2013/05/23 13:35:44 I think this should be the same as our minSdkVersi Show quoted text On 2013/05/16 12:06:26, Wladimir Palant wrote: > This is pretty random - I simply chose it because V8 compiles for the android-9 > platform. android-3 platform works fine as well but probably doesn't make too > much sense if we use V8 code. I think this should be the same as our minSdkVersion, android-7. I think code compiled for a new platform won't work on older Android versions, but I'm not sure.
32 APP_STL=gnustl_static \	32 APP_STL=gnustl_static \

33 APP_BUILD_SCRIPT=Makefile \	33 APP_BUILD_SCRIPT=Makefile \

34 NDK_PROJECT_PATH=. \	34 NDK_PROJECT_PATH=. \

35 NDK_OUT=. \	35 NDK_OUT=. \

36 NDK_APP_DST_DIR=android_arm.release	36 NDK_APP_DST_DIR=android_arm.release

LEFT	RIGHT