Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10488022: Added Android build target (Closed)

Created:
May 16, 2013, 10:23 a.m. by Wladimir Palant
Modified:
May 24, 2013, 12:46 p.m.
Visibility:
Public.

Description

This builds upon http://codereview.adblockplus.org/10228016/ but avoids having to configure toolchains manually by invoking ndk-build.

Patch Set 1 #

Total comments: 11

Patch Set 2 : Review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -17 lines) Patch
M Makefile View 1 1 chunk +24 lines, -1 line 0 comments Download
M common.gypi View 1 1 chunk +12 lines, -5 lines 0 comments Download
M libadblockplus.gyp View 1 3 chunks +14 lines, -5 lines 0 comments Download
M test/DefaultFileSystem.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M test/FileSystemJsObject.cpp View 1 2 chunks +5 lines, -2 lines 0 comments Download
A third_party/v8_gyp_launcher View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Wladimir Palant
May 16, 2013, 10:23 a.m. (2013-05-16 10:23:29 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/10488022/diff/1/common.gypi File common.gypi (right): http://codereview.adblockplus.org/10488022/diff/1/common.gypi#newcode15 common.gypi:15: '-pedantic', '-std=gnu++0x', '-fexceptions', ], -Wno-error flags were merely left-overs ...
May 16, 2013, 10:32 a.m. (2013-05-16 10:32:19 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/10488022/diff/1/Makefile File Makefile (right): http://codereview.adblockplus.org/10488022/diff/1/Makefile#newcode31 Makefile:31: APP_PLATFORM=android-9 \ This is pretty random - I simply ...
May 16, 2013, 12:06 p.m. (2013-05-16 12:06:26 UTC) #3
Felix Dahlke
http://codereview.adblockplus.org/10488022/diff/1/Makefile File Makefile (right): http://codereview.adblockplus.org/10488022/diff/1/Makefile#newcode20 Makefile:20: test -d third_party/v8/build/gyp || mkdir third_party/v8/build/gyp How about "mkdir ...
May 23, 2013, 1:35 p.m. (2013-05-23 13:35:43 UTC) #4
Wladimir Palant
This is meant to be applied on top of the changes in http://codereview.adblockplus.org/10727002/ now meaning ...
May 24, 2013, 8:41 a.m. (2013-05-24 08:41:56 UTC) #5
Wladimir Palant
http://codereview.adblockplus.org/10488022/diff/1/Makefile File Makefile (right): http://codereview.adblockplus.org/10488022/diff/1/Makefile#newcode20 Makefile:20: test -d third_party/v8/build/gyp || mkdir third_party/v8/build/gyp On 2013/05/23 13:35:44, ...
May 24, 2013, 8:47 a.m. (2013-05-24 08:47:36 UTC) #6
Felix Dahlke
May 24, 2013, 10:40 a.m. (2013-05-24 10:40:28 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld