Issue 10727002: Get rid of dependencies on v8.h in public header files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10727002: Get rid of dependencies on v8.h in public header files (Closed)

Created:
May 23, 2013, 2:43 p.m. by Wladimir Palant

Modified:
May 27, 2013, 9:37 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

This removes JsEngine::Context and JsError from public header files; then the remaining dependencies on V8 are replaced by forward declarations (requires using auto_ptr for two properties unfortunately).

Patch Set 1 #

Patch Set 2 : Added helper class to make using v8 values via auto_ptr less awkward #

Total comments: 3

Created: May 23, 2013, 4:08 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+321 lines, -123 lines)			Patch
M	include/AdblockPlus/JsEngine.h	View	1	2 chunks	+13 lines, -21 lines	1 comment	Download
M	include/AdblockPlus/JsValue.h	View	1	2 chunks	+9 lines, -2 lines	1 comment	Download
A	include/AdblockPlus/V8ValueHolder.h	View	1	1 chunk	+93 lines, -0 lines	1 comment	Download
M	libadblockplus.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/ConsoleJsObject.cpp	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/FileSystemJsObject.cpp	View		6 chunks	+6 lines, -6 lines	0 comments	Download
A	src/JsContext.h	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A	src/JsContext.cpp	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/JsEngine.cpp	View	1	5 chunks	+10 lines, -36 lines	0 comments	Download
A	src/JsError.h	View		1 chunk	+53 lines, -0 lines	0 comments	Download
A	src/JsError.cpp	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/JsValue.cpp	View	1	1 chunk	+38 lines, -52 lines	0 comments	Download
M	src/WebRequestJsObject.cpp	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	test/JsEngine.cpp	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Felix Dahlke

LGTM with some nits fixed. http://codereview.adblockplus.org/10727002/diff/3001/include/AdblockPlus/JsEngine.h File include/AdblockPlus/JsEngine.h (right): http://codereview.adblockplus.org/10727002/diff/3001/include/AdblockPlus/JsEngine.h#newcode40 include/AdblockPlus/JsEngine.h:40: template <class T> class ...

May 24, 2013, 3:45 p.m. (2013-05-24 15:45:41 UTC) #3

Wladimir Palant

May 27, 2013, 9:37 a.m. (2013-05-27 09:37:40 UTC) #4

Fixed the nits:
https://hg.adblockplus.org/libadblockplus/rev/452a224bf79e
https://hg.adblockplus.org/libadblockplus/rev/37b3fc2695c6

Expand All Messages | Collapse All Messages