Get rid of dependencies on v8.h in public header files

include/AdblockPlus/V8ValueHolder.h

Index: include/AdblockPlus/V8ValueHolder.h
===================================================================
new file mode 100644
--- /dev/null
+++ b/include/AdblockPlus/V8ValueHolder.h
@@ -0,0 +1,93 @@
+/*
+ * This file is part of Adblock Plus <http://adblockplus.org/>,
+ * Copyright (C) 2006-2013 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef ADBLOCK_PLUS_V8_VALUE_HOLDER_H
+#define ADBLOCK_PLUS_V8_VALUE_HOLDER_H
+
+#include <memory>
+
+namespace v8
+{
+  class Isolate;
+  template <class T> class Handle;
+  template <class T> class Persistent;
+}
+
+namespace AdblockPlus
+{
+  template<class T>
+  class V8ValueHolder
+  {
+  public:
+    inline V8ValueHolder() {}

[Felix Dahlke, 2013/05/24 15:45:41]

Inline functions in classes are inline per default, no need for the keyword.

+    inline V8ValueHolder(V8ValueHolder& value)
+    {
+      reset(value.isolate, static_cast<v8::Handle<T> >(value));
+    }
+    inline V8ValueHolder(v8::Isolate* isolate, v8::Persistent<T> value)
+    {
+      reset(isolate, value);
+    }
+    inline V8ValueHolder(v8::Isolate* isolate, v8::Handle<T> value)
+    {
+      reset(isolate, value);
+    }
+
+    inline ~V8ValueHolder()
+    {
+      reset(0, v8::Persistent<T>());
+    }
+
+    inline void reset(v8::Isolate* isolate, v8::Persistent<T> value)
+    {
+      if (this->value.get())
+      {
+        this->value->Dispose(this->isolate);
+        this->value.reset(0);
+      }
+
+      if (!value.IsEmpty())
+      {
+        this->isolate = isolate;
+        this->value.reset(new v8::Persistent<T>(value));
+      }
+    }
+
+    inline void reset(v8::Isolate* isolate, v8::Handle<T> value)
+    {
+      reset(isolate, v8::Persistent<T>::New(isolate, value));
+    }
+
+    inline T* operator->() const
+    {
+      return **value;
+    }
+    inline operator v8::Handle<T>() const
+    {
+      return *value;
+    }
+    inline operator v8::Persistent<T>() const
+    {
+      return *value;
+    }
+  private:
+    v8::Isolate* isolate;
+    std::auto_ptr<v8::Persistent<T> > value;
+  };
+}
+
+#endif