Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: src/plugin/BuildVariant.h
Issue
10783032
:
Pass browser locale to the JS code (Closed)
Patch Set: Fixed review comments
Created June 4, 2013, 11:25 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Fixed review comments
Right:
Patch Set 1: None
Patch Set 2: Fixed review comments
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
src/engine/main.cpp
src/plugin/AdblockPlusClient.cpp
src/plugin/BuildVariant.h
src/plugin/PluginClass.cpp
src/plugin/PluginClassThread.cpp
src/shared/Version.h
View unified diff
|
Download patch
« no previous file with comments
|
« src/plugin/AdblockPlusClient.cpp
('k') |
src/plugin/PluginClass.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 #include "Plugin.h"
1 #include "Plugin.h"
2
#include "Version.h"
2
#include "
../shared/
Version.h"
OLD
NEW
« no previous file with comments
|
« src/plugin/AdblockPlusClient.cpp
('k') |
src/plugin/PluginClass.cpp »
('j') |
no next file with comments »
Edit Message
Issue 10783032: Pass browser locale to the JS code (Closed)
Created June 4, 2013, 8:57 a.m. by Wladimir Palant
Modified June 19, 2013, 5:24 p.m.
Reviewers: Felix Dahlke, Oleksandr
Base URL:
Comments: 5
This is Rietveld