Pass browser locale to the JS code

Pass browser locale to the JS code

[Felix Dahlke, 2013-06-04 09:46:09]

http://codereview.adblockplus.org/10783032/diff/1/src/engine/main.cpp
File src/engine/main.cpp (right):

http://codereview.adblockplus.org/10783032/diff/1/src/engine/main.cpp#newcode167
src/engine/main.cpp:167: AdblockPlus::AppInfo appInfo;
The version's missing, would like to see at least a TODO for that. I suppose the
version should be passed into the engine as well?

http://codereview.adblockplus.org/10783032/diff/1/src/engine/main.cpp#newcode189
src/engine/main.cpp:189: LPWSTR* argv = CommandLineToArgvW(GetCommandLineW(),
&argc);
According to the docs, you need to free argv using LocalFree.

http://codereview.adblockplus.org/10783032/diff/1/src/plugin/AdblockPlusClien...
File src/plugin/AdblockPlusClient.cpp (right):

http://codereview.adblockplus.org/10783032/diff/1/src/plugin/AdblockPlusClien...
src/plugin/AdblockPlusClient.cpp:33:
browserLanguage.GetBuffer(browserLanguage.GetLength() + 1),
I'd prefer const_cast<LPWSTR>(browserLanguage.c_str()). Does the same and it's
shorter.

[Wladimir Palant, 2013-06-04 11:28:45]

I've made sure to set AppInfo.version as well now. This field doesn't need to be
passed in as command line parameter - it's fixed at compile time anyway. So I
moved Version.h into the shared directory and changed IEPLUGIN_VERSION a Unicode
string (saves us a bunch of conversions because most of the time it is a
parameter to the CString constructor anyway).

http://codereview.adblockplus.org/10783032/diff/1/src/plugin/AdblockPlusClien...
File src/plugin/AdblockPlusClient.cpp (right):

http://codereview.adblockplus.org/10783032/diff/1/src/plugin/AdblockPlusClien...
src/plugin/AdblockPlusClient.cpp:33:
browserLanguage.GetBuffer(browserLanguage.GetLength() + 1),
No, it doesn't do the same thing (besides, browserLanguage is a CString, not
std::string). According to the docs, CreateProcessAsUserW might write to the
buffer passed in - GetBuffer() informs the CString class about that. Messing
with the internal buffer without calling GetBuffer() isn't recommended.

[Felix Dahlke, 2013-06-04 11:34:20]

LGTM

http://codereview.adblockplus.org/10783032/diff/1/src/plugin/AdblockPlusClien...
File src/plugin/AdblockPlusClient.cpp (right):

http://codereview.adblockplus.org/10783032/diff/1/src/plugin/AdblockPlusClien...
src/plugin/AdblockPlusClient.cpp:33:
browserLanguage.GetBuffer(browserLanguage.GetLength() + 1),
On 2013/06/04 11:28:45, Wladimir Palant wrote:
> No, it doesn't do the same thing (besides, browserLanguage is a CString, not
> std::string).

Oh, tought it had c_str() or some equivalent. Well it appears it implements the
cast operator, so it can just be const_cast<LPWSTR>(browserLanguage).

According to the docs, CreateProcessAsUserW might write to the
> buffer passed in - GetBuffer() informs the CString class about that. Messing
> with the internal buffer without calling GetBuffer() isn't recommended.

Oh, you're right. From the docs: "The Unicode version of this function,
CreateProcessAsUserW, can modify the contents of this string."

Seems I missed that. GetBuffer is indeed better then.