Send debug output to a file

src/engine/Debug.cpp

 #include "stdafx.h"
 
 #include <fstream>
 #include <stdio.h>
 
 #include "Debug.h"
 #include "Utils.h"
 
 #ifdef _DEBUG

[Felix Dahlke, 2013/06/04 06:57:58]

I assume this is something defined in the plugin?

Just for the record, identifiers beginning with _ are reserved for the
implementation (i.e. compiler and standard library), and we should get rid of
them at some point. But I'm happy with not adding new ones for now.

[Wladimir Palant, 2013/06/04 09:33:59]

No, this is defined by the compiler.

[Felix Dahlke, 2013/06/04 09:39:09]

Hm, didn't know that one, seems to be MSVS only. But well, we can fix that if it
becomes a problem.

 
 namespace
 {
   class CriticalSection
   {
   public:
     CriticalSection()
     {
       InitializeCriticalSection(&section);
     }
 
     ~CriticalSection()

[Felix Dahlke, 2013/06/04 06:57:58]

Rule of Three again :P I suggest making copy constructor and copy assignment
operator private. This is going to crash when copied otherwise.

     {
       DeleteCriticalSection(&section);
     }
 
     class Lock
     {
     public:
       Lock(CriticalSection& cs)
           : section(&cs.section)
       {
         EnterCriticalSection(section);
       }
 
       ~Lock()

[Felix Dahlke, 2013/06/04 06:57:58]

Same as above, should have a private copy constructor and copy assignment
operator.

       {
         LeaveCriticalSection(section);
       }
     private:
       LPCRITICAL_SECTION section;
+      Lock(const Lock&);
+      Lock& operator=(const Lock&);
     };
   private:
     CRITICAL_SECTION section;
+    CriticalSection(const CriticalSection&);
+    CriticalSection& operator=(const CriticalSection&);
   };
 
-  static CriticalSection debugLock;

[Felix Dahlke, 2013/06/04 06:57:58]

static in namespaces is deprecated in C++. Don't think it has any effect anyway.

+  CriticalSection debugLock;
 }
 
 void Debug(const std::string& text)
 {
   SYSTEMTIME st;
   ::GetSystemTime(&st);
 
   char timeBuf[14];
   _snprintf_s(timeBuf, _TRUNCATE, "%02i:%02i:%02i.%03i", st.wHour, st.wMinute, st.wSecond, st.wMilliseconds);
 
   std::wstring filePath = GetAppDataPath() + L"\\debug_engine.txt";
 
   CriticalSection::Lock lock(debugLock);
   std::ofstream out(filePath, std::ios::app);
   out << timeBuf << " - " << text << std::endl;
   out.flush();
 }
 
 void DebugLastError(const std::string& message)
 {
   std::stringstream stream;
   stream << message << " (Error code: " << GetLastError() << ")";
   Debug(stream.str());
 }
 
 void DebugException(const std::exception& exception)
 {
   Debug(std::string("An exception occurred: ") + exception.what());
 }
-
+#else
+void Debug(const std::string& text) {}

[Felix Dahlke, 2013/06/04 09:39:09]

These are already defined in Debug.h, no?

[Wladimir Palant, 2013/06/04 10:17:01]

No, not any more - Oleksandr moved them in a different patch.

+void DebugLastError(const std::string& message) {}
+void DebugException(const std::exception& exception) {}
 #endif // _DEBUG