Send debug output to a file

Send debug output to a file

[Felix Dahlke, 2013-06-04 06:57:58]

http://codereview.adblockplus.org/10790071/diff/1/src/engine/Debug.cpp
File src/engine/Debug.cpp (right):

http://codereview.adblockplus.org/10790071/diff/1/src/engine/Debug.cpp#newcode9
src/engine/Debug.cpp:9: #ifdef _DEBUG
I assume this is something defined in the plugin?

Just for the record, identifiers beginning with _ are reserved for the
implementation (i.e. compiler and standard library), and we should get rid of
them at some point. But I'm happy with not adding new ones for now.

http://codereview.adblockplus.org/10790071/diff/1/src/engine/Debug.cpp#newcode21
src/engine/Debug.cpp:21: ~CriticalSection()
Rule of Three again :P I suggest making copy constructor and copy assignment
operator private. This is going to crash when copied otherwise.

http://codereview.adblockplus.org/10790071/diff/1/src/engine/Debug.cpp#newcode35
src/engine/Debug.cpp:35: ~Lock()
Same as above, should have a private copy constructor and copy assignment
operator.

http://codereview.adblockplus.org/10790071/diff/1/src/engine/Debug.cpp#newcode46
src/engine/Debug.cpp:46: static CriticalSection debugLock;
static in namespaces is deprecated in C++. Don't think it has any effect anyway.

[Wladimir Palant, 2013-06-04 09:33:59]

I implemented the suggestions.

http://codereview.adblockplus.org/10790071/diff/1/src/engine/Debug.cpp
File src/engine/Debug.cpp (right):

http://codereview.adblockplus.org/10790071/diff/1/src/engine/Debug.cpp#newcode9
src/engine/Debug.cpp:9: #ifdef _DEBUG
No, this is defined by the compiler.

[Felix Dahlke, 2013-06-04 09:39:09]

LGTM, assuming the functions Debug() etc. are not defined inline in Debug.h
anymore, don't see that change here.

http://codereview.adblockplus.org/10790071/diff/1/src/engine/Debug.cpp
File src/engine/Debug.cpp (right):

http://codereview.adblockplus.org/10790071/diff/1/src/engine/Debug.cpp#newcode9
src/engine/Debug.cpp:9: #ifdef _DEBUG
On 2013/06/04 09:33:59, Wladimir Palant wrote:
> No, this is defined by the compiler.

Hm, didn't know that one, seems to be MSVS only. But well, we can fix that if it
becomes a problem.

http://codereview.adblockplus.org/10790071/diff/5001/src/engine/Debug.cpp
File src/engine/Debug.cpp (right):

http://codereview.adblockplus.org/10790071/diff/5001/src/engine/Debug.cpp#new...
src/engine/Debug.cpp:81: void Debug(const std::string& text) {}
These are already defined in Debug.h, no?

[Wladimir Palant, 2013-06-04 10:17:00]

http://codereview.adblockplus.org/10790071/diff/5001/src/engine/Debug.cpp
File src/engine/Debug.cpp (right):

http://codereview.adblockplus.org/10790071/diff/5001/src/engine/Debug.cpp#new...
src/engine/Debug.cpp:81: void Debug(const std::string& text) {}
On 2013/06/04 09:39:09, Felix H. Dahlke wrote:
> These are already defined in Debug.h, no?

No, not any more - Oleksandr moved them in a different patch.