First-run page (Chrome-specific changes)

File paths indicate that the file is the same as in the Firefox version.

[Wladimir Palant, 2013-05-28 13:45:28]

http://codereview.adblockplus.org/10803010/diff/1/_locales/en_US/messages.json
File _locales/en_US/messages.json (right):

http://codereview.adblockplus.org/10803010/diff/1/_locales/en_US/messages.jso...
_locales/en_US/messages.json:74: },
Please don't duplicate the messages we have in Firefox - they should be added to
import_locales section of metadata.chrome.

http://codereview.adblockplus.org/10803010/diff/1/firstRun.html
File firstRun.html (right):

http://codereview.adblockplus.org/10803010/diff/1/firstRun.html#newcode1
firstRun.html:1: ../abp/chrome/content/ui/firstRun.html
Is that a symbolic link? This file should be added to the [mapping] section of
metadata.chrome and imported from the adblockplus subrepository on build.

http://codereview.adblockplus.org/10803010/diff/1/firstRun.js
File firstRun.js (right):

http://codereview.adblockplus.org/10803010/diff/1/firstRun.js#newcode1
firstRun.js:1: ../abp/chrome/content/ui/firstRun.js
Same here, please add to the [mapping] section.

http://codereview.adblockplus.org/10803010/diff/1/skin/firstRun.css
File skin/firstRun.css (right):

http://codereview.adblockplus.org/10803010/diff/1/skin/firstRun.css#newcode1
skin/firstRun.css:1: ../../abp/chrome/skin/firstRun.css
Same here, please add to the [mapping] section - and the same for the shared
images of course.

[Thomas Greiner, 2013-05-28 17:35:12]

http://codereview.adblockplus.org/10803010/diff/1/_locales/en_US/messages.json
File _locales/en_US/messages.json (right):

http://codereview.adblockplus.org/10803010/diff/1/_locales/en_US/messages.jso...
_locales/en_US/messages.json:74: },
On 2013/05/28 13:45:28, Wladimir Palant wrote:
> Please don't duplicate the messages we have in Firefox - they should be added
to
> import_locales section of metadata.chrome.

Done.

http://codereview.adblockplus.org/10803010/diff/1/firstRun.html
File firstRun.html (right):

http://codereview.adblockplus.org/10803010/diff/1/firstRun.html#newcode1
firstRun.html:1: ../abp/chrome/content/ui/firstRun.html
On 2013/05/28 13:45:28, Wladimir Palant wrote:
> Is that a symbolic link? This file should be added to the [mapping] section of
> metadata.chrome and imported from the adblockplus subrepository on build.

Yes, as mentioned in the issue description.

Done.

http://codereview.adblockplus.org/10803010/diff/1/firstRun.js
File firstRun.js (right):

http://codereview.adblockplus.org/10803010/diff/1/firstRun.js#newcode1
firstRun.js:1: ../abp/chrome/content/ui/firstRun.js
On 2013/05/28 13:45:28, Wladimir Palant wrote:
> Same here, please add to the [mapping] section.

Done.

http://codereview.adblockplus.org/10803010/diff/1/skin/firstRun.css
File skin/firstRun.css (right):

http://codereview.adblockplus.org/10803010/diff/1/skin/firstRun.css#newcode1
skin/firstRun.css:1: ../../abp/chrome/skin/firstRun.css
On 2013/05/28 13:45:28, Wladimir Palant wrote:
> Same here, please add to the [mapping] section - and the same for the shared
> images of course.

Done.

[Wladimir Palant, 2013-05-29 06:00:56]

LGTM with the nit fixed

http://codereview.adblockplus.org/10803010/diff/10001/metadata.chrome
File metadata.chrome (right):

http://codereview.adblockplus.org/10803010/diff/10001/metadata.chrome#newcode95
metadata.chrome:95: adblockplus/chrome/locale/*/firstRun.properties =
=firstRun_title
I don't think you need to list each string here, =* will do.