Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10807053: Add developmentBuild to AppInfo (Closed)

Created:
June 5, 2013, 9:18 a.m. by Felix Dahlke
Modified:
June 5, 2013, 10:08 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Add developmentBuild to AppInfo

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M include/AdblockPlus/AppInfo.h View 1 chunk +3 lines, -0 lines 1 comment Download
M src/AppInfoJsObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M test/AppInfoJsObject.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Felix Dahlke
Also made sure that it's initialised to false.
June 5, 2013, 9:20 a.m. (2013-06-05 09:20:01 UTC) #1
Felix Dahlke
June 5, 2013, 9:20 a.m. (2013-06-05 09:20:12 UTC) #2
Wladimir Palant
June 5, 2013, 9:28 a.m. (2013-06-05 09:28:35 UTC) #3
LGTM

http://codereview.adblockplus.org/10807053/diff/1/include/AdblockPlus/AppInfo.h
File include/AdblockPlus/AppInfo.h (right):

http://codereview.adblockplus.org/10807053/diff/1/include/AdblockPlus/AppInfo...
include/AdblockPlus/AppInfo.h:32: bool developmentBuild;
"bool release" would have been a more straightforward choice IMHO but fine
either way.

Powered by Google App Engine
This is Rietveld