Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10850030: Remove support for KMeleon devbuilds and add (somewhat hacky) support for IE devbuilds (Closed)

Created:
June 12, 2013, 1:11 p.m. by Wladimir Palant
Modified:
June 19, 2013, 5:23 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

We cannot actually compile the builds so they are expected to be already in the directory, merely generating the listing and update file is automated. The current scripts aren`t meant for builds with multiple files per version so I use a rather unconventional hack - "-x64.msi" is declared to be the package suffix and I deduce the URL of the x86 download from the x64 one. I also replace the built-in filesizeformat template filter by own custom one - the former doesn`t work correctly on my machine for some reason (it currently works on the server but might stop working on update).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -14 lines) Patch
M .sitescripts.example View 1 chunk +0 lines, -4 lines 0 comments Download
M sitescripts/extensions/bin/createNightlies.py View 4 chunks +49 lines, -3 lines 0 comments Download
M sitescripts/extensions/template/nightlies.html View 2 chunks +6 lines, -5 lines 0 comments Download
M sitescripts/extensions/utils.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
June 12, 2013, 1:11 p.m. (2013-06-12 13:11:21 UTC) #1
Felix Dahlke
June 19, 2013, 11:43 a.m. (2013-06-19 11:43:01 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld