Pass developmentBuild info to libadblockplus

Pass developmentBuild info to libadblockplus

[Wladimir Palant, 2013-06-05 09:54:05]

http://codereview.adblockplus.org/10894013/diff/1/AdblockPlusEngine.vcxproj
File AdblockPlusEngine.vcxproj (right):

http://codereview.adblockplus.org/10894013/diff/1/AdblockPlusEngine.vcxproj#n...
AdblockPlusEngine.vcxproj:173:
<LibraryPath>$(ProjectDir)libadblockplus\build\ia32\build\Release\lib;$(LibraryPath)</LibraryPath>
Please define ADBLOCK_PLUS_PRODUCTION_MODE here (as well as WIN32, NDEBUG and
_WINDOWS I guess).

http://codereview.adblockplus.org/10894013/diff/1/AdblockPlusEngine.vcxproj#n...
AdblockPlusEngine.vcxproj:182:
<PreprocessorDefinitions>WIN32;_DEBUG;_WINDOWS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Please define ADBLOCK_PLUS_PRODUCTION_MODE here.

http://codereview.adblockplus.org/10894013/diff/1/AdblockPlusEngine.vcxproj#n...
AdblockPlusEngine.vcxproj:198:
<PreprocessorDefinitions>WIN32;_DEBUG;_WINDOWS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Please define ADBLOCK_PLUS_TEST_MODE here.

http://codereview.adblockplus.org/10894013/diff/1/AdblockPlusEngine.vcxproj#n...
AdblockPlusEngine.vcxproj:214:
<PreprocessorDefinitions>WIN32;_DEBUG;_WINDOWS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
Please define ADBLOCK_PLUS_TEST_MODE here.

http://codereview.adblockplus.org/10894013/diff/1/src/engine/main.cpp
File src/engine/main.cpp (right):

http://codereview.adblockplus.org/10894013/diff/1/src/engine/main.cpp#newcode174
src/engine/main.cpp:174: appInfo.developmentBuild = true;
Please add #else and set it to false explicitly in production mode - I wouldn't
want to rely on implicit initialization behavior.

[Felix Dahlke, 2013-06-05 10:12:36]

Adressed the issues

http://codereview.adblockplus.org/10894013/diff/1/AdblockPlusEngine.vcxproj
File AdblockPlusEngine.vcxproj (right):

http://codereview.adblockplus.org/10894013/diff/1/AdblockPlusEngine.vcxproj#n...
AdblockPlusEngine.vcxproj:173:
<LibraryPath>$(ProjectDir)libadblockplus\build\ia32\build\Release\lib;$(LibraryPath)</LibraryPath>
On 2013/06/05 09:54:05, Wladimir Palant wrote:
> Please define ADBLOCK_PLUS_PRODUCTION_MODE here (as well as WIN32, NDEBUG and
> _WINDOWS I guess).

Where exactly? In this PropertyGroup?

http://codereview.adblockplus.org/10894013/diff/1/AdblockPlusEngine.vcxproj#n...
AdblockPlusEngine.vcxproj:182:
<PreprocessorDefinitions>WIN32;_DEBUG;_WINDOWS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
On 2013/06/05 09:54:05, Wladimir Palant wrote:
> Please define ADBLOCK_PLUS_PRODUCTION_MODE here.

Done.

http://codereview.adblockplus.org/10894013/diff/1/AdblockPlusEngine.vcxproj#n...
AdblockPlusEngine.vcxproj:198:
<PreprocessorDefinitions>WIN32;_DEBUG;_WINDOWS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
On 2013/06/05 09:54:05, Wladimir Palant wrote:
> Please define ADBLOCK_PLUS_TEST_MODE here.

Done.

http://codereview.adblockplus.org/10894013/diff/1/AdblockPlusEngine.vcxproj#n...
AdblockPlusEngine.vcxproj:214:
<PreprocessorDefinitions>WIN32;_DEBUG;_WINDOWS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
On 2013/06/05 09:54:05, Wladimir Palant wrote:
> Please define ADBLOCK_PLUS_TEST_MODE here.

Done.

http://codereview.adblockplus.org/10894013/diff/1/src/engine/main.cpp
File src/engine/main.cpp (right):

http://codereview.adblockplus.org/10894013/diff/1/src/engine/main.cpp#newcode174
src/engine/main.cpp:174: appInfo.developmentBuild = true;
On 2013/06/05 09:54:05, Wladimir Palant wrote:
> Please add #else and set it to false explicitly in production mode - I
wouldn't
> want to rely on implicit initialization behavior.

Fair enough, wouldn't hurt.

[Wladimir Palant, 2013-06-05 10:29:07]

LGTM

http://codereview.adblockplus.org/10894013/diff/1/AdblockPlusEngine.vcxproj
File AdblockPlusEngine.vcxproj (right):

http://codereview.adblockplus.org/10894013/diff/1/AdblockPlusEngine.vcxproj#n...
AdblockPlusEngine.vcxproj:173:
<LibraryPath>$(ProjectDir)libadblockplus\build\ia32\build\Release\lib;$(LibraryPath)</LibraryPath>
On 2013/06/05 10:12:36, Felix H. Dahlke wrote:
> On 2013/06/05 09:54:05, Wladimir Palant wrote:
> > Please define ADBLOCK_PLUS_PRODUCTION_MODE here (as well as WIN32, NDEBUG
and
> > _WINDOWS I guess).
> 
> Where exactly? In this PropertyGroup?

My bad, wrong section - you fixed Release Production|Win32 correctly below.