Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10960026: Sync devbuilds to downloads.adblockplus.org (Closed)

Created:
June 19, 2013, 10:03 a.m. by Felix Dahlke
Modified:
Nov. 12, 2013, 10:12 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Note that I was unable to test this, since there's an issue with my Vagrant/VirtualBox right now and I can't seem to fix it quickly.

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
A modules/downloadserver/files/known_hosts View 1 chunk +2 lines, -0 lines 0 comments Download
M modules/downloadserver/manifests/init.pp View 1 chunk +45 lines, -0 lines 1 comment Download
A modules/private-stub/files/rsync@downloads.adblockplus.org View 1 chunk +27 lines, -0 lines 0 comments Download
A modules/private-stub/files/rsync@downloads.adblockplus.org.pub View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
Felix Dahlke
June 19, 2013, 10:06 a.m. (2013-06-19 10:06:17 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/10960026/diff/3001/modules/downloadserver/manifests/init.pp File modules/downloadserver/manifests/init.pp (right): http://codereview.adblockplus.org/10960026/diff/3001/modules/downloadserver/manifests/init.pp#newcode139 modules/downloadserver/manifests/init.pp:139: command => 'rsync -e ssh -ltprz rsync@adblockplus.org:. /var/www/downloads/devbuilds', 1) ...
June 19, 2013, 10:43 a.m. (2013-06-19 10:43:44 UTC) #2
Felix Dahlke
Issues addressed (partly by you), closing this.
June 19, 2013, 11:36 a.m. (2013-06-19 11:36:20 UTC) #3
Wladimir Palant
June 19, 2013, 1:06 p.m. (2013-06-19 13:06:16 UTC) #4
On 2013/06/19 11:36:20, Felix H. Dahlke wrote:
> Issues addressed (partly by you), closing this.

Yes, LGTM as it is now :)

Powered by Google App Engine
This is Rietveld