Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10964120: Made Synchronizer tests work again (Closed)

Created:
July 12, 2013, 1:43 p.m. by Wladimir Palant
Modified:
July 25, 2013, 11:23 a.m.
Visibility:
Public.

Description

I didn`t bother converting tests for features we don`t want to keep, so the only part really missing is checksum verification.

Patch Set 1 #

Patch Set 2 : Updated for Synchronizer changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+706 lines, -813 lines) Patch
M chrome/content/common.js View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/content/index.html View 1 chunk +17 lines, -12 lines 0 comments Download
M chrome/content/tests/subscriptionClasses.js View 1 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/content/tests/synchronizer.js View 1 1 chunk +683 lines, -795 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
July 12, 2013, 1:43 p.m. (2013-07-12 13:43:13 UTC) #1
Wladimir Palant
The unit tests have been updated to consider the Synchronizer changes from http://codereview.adblockplus.org/11153017/. I've also ...
July 17, 2013, 12:35 p.m. (2013-07-17 12:35:51 UTC) #2
Felix Dahlke
July 25, 2013, 11:15 a.m. (2013-07-25 11:15:07 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld