Switch to bwm-ng for bandwidth monitoring

Unlike vnstat, bwm-ng is available for both Ubuntu and OpenSUSE. It seems to be generally more usable in batch mode.

[Wladimir Palant, 2013-06-28 10:12:22]

http://codereview.adblockplus.org/10992045/diff/1/modules/nagios/files/check_...
File modules/nagios/files/check_bandwidth (right):

http://codereview.adblockplus.org/10992045/diff/1/modules/nagios/files/check_...
modules/nagios/files/check_bandwidth:23: vnstat_output =
subprocess.check_output(["bwm-ng", "-I", "eth0", "-t", "5000", "-c", "1", "-o",
"csv"])
Oops, maybe I should have changed the name of that variable :)

http://codereview.adblockplus.org/10992045/diff/1/modules/nagios/files/check_...
modules/nagios/files/check_bandwidth:29: perfdata = "rx=%i;%s;%s tx=%i;%s;%s" %
(rx, warn, crit, tx, warn, crit)
Might be better to use %i for the other parameters as well.

[Felix Dahlke, 2013-07-02 09:55:32]

http://codereview.adblockplus.org/10992045/diff/1/modules/nagios/files/check_...
File modules/nagios/files/check_bandwidth (right):

http://codereview.adblockplus.org/10992045/diff/1/modules/nagios/files/check_...
modules/nagios/files/check_bandwidth:6: if bits >= 2000000:
Shouldn't it be 1000000 here and 1000 below?

http://codereview.adblockplus.org/10992045/diff/1/modules/nagios/files/check_...
modules/nagios/files/check_bandwidth:23: vnstat_output =
subprocess.check_output(["bwm-ng", "-I", "eth0", "-t", "5000", "-c", "1", "-o",
"csv"])
On 2013/06/28 10:12:22, Wladimir Palant wrote:
> Oops, maybe I should have changed the name of that variable :)

Yup, please do :P

http://codereview.adblockplus.org/10992045/diff/1/modules/nagios/files/check_...
modules/nagios/files/check_bandwidth:29: perfdata = "rx=%i;%s;%s tx=%i;%s;%s" %
(rx, warn, crit, tx, warn, crit)
On 2013/06/28 10:12:22, Wladimir Palant wrote:
> Might be better to use %i for the other parameters as well.

Yes, no idea why I didn't.

[Wladimir Palant, 2013-07-02 10:25:16]

Comments addressed.

http://codereview.adblockplus.org/10992045/diff/1/modules/nagios/files/check_...
File modules/nagios/files/check_bandwidth (right):

http://codereview.adblockplus.org/10992045/diff/1/modules/nagios/files/check_...
modules/nagios/files/check_bandwidth:6: if bits >= 2000000:
On 2013/07/02 09:55:32, Felix H. Dahlke wrote:
> Shouldn't it be 1000000 here and 1000 below?

Not sure, I slightly remember that 1610 kbit/s is more readable than 1.61
Mbit/s. But it doesn't really matter, I can fix that.

[Felix Dahlke, 2013-07-02 10:26:49]

LGTM