Hanging resolved (critical sections unlocking)

src/engine/Debug.cpp

 #include <fstream>
 #include <stdio.h>
 #include <sstream>
 #include <Windows.h>
 
 #include "../shared/Utils.h"
 
 #include "Debug.h"
 
 #ifdef _DEBUG
 
-namespace
-{
-  class CriticalSection
-  {
-  public:
-    CriticalSection()
-    {
-      InitializeCriticalSection(&section);
-    }
-
-    ~CriticalSection()
-    {
-      DeleteCriticalSection(&section);
-    }
-
-    class Lock
-    {
-    public:
-      Lock(CriticalSection& cs)
-          : section(&cs.section)
-      {
-        EnterCriticalSection(section);
-      }
-
-      ~Lock()
-      {
-        LeaveCriticalSection(section);
-      }
-    private:
-      LPCRITICAL_SECTION section;
-      Lock(const Lock&);
-      Lock& operator=(const Lock&);
-    };
-  private:
-    CRITICAL_SECTION section;
-    CriticalSection(const CriticalSection&);
-    CriticalSection& operator=(const CriticalSection&);
-  };
-
-  CriticalSection debugLock;
-}
+CriticalSection debugLock;

[Wladimir Palant, 2013/06/17 12:57:24]

IMHO this should be kept inside the anonymous namespace.

 
 void Debug(const std::string& text)
 {
   SYSTEMTIME st;
   ::GetSystemTime(&st);
 
   char timeBuf[14];
   _snprintf_s(timeBuf, _TRUNCATE, "%02i:%02i:%02i.%03i", st.wHour, st.wMinute, st.wSecond, st.wMilliseconds);
 
   std::wstring filePath = GetAppDataPath() + L"\\debug_engine.txt";
@@ skipping 13 matching lines @@
 
 void DebugException(const std::exception& exception)
 {
   Debug(std::string("An exception occurred: ") + exception.what());
 }
 #else
 void Debug(const std::string& text) {}
 void DebugLastError(const std::string& message) {}
 void DebugException(const std::exception& exception) {}
 #endif // _DEBUG