Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11012013: Hanging resolved (critical sections unlocking) (Closed)

Created:
June 14, 2013, 12:17 p.m. by Oleksandr
Modified:
June 25, 2013, 12:22 p.m.
Visibility:
Public.

Description

Hanging resolved (critical sections unlocking)

Patch Set 1 #

Patch Set 2 : Using CriticalSection class instead #

Total comments: 3

Patch Set 3 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -42 lines) Patch
M src/engine/Debug.cpp View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M src/plugin/PluginFilter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/plugin/PluginFilter.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A src/shared/CriticalSection.h View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M src/shared/Utils.h View 1 2 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 8
Oleksandr
June 14, 2013, 12:37 p.m. (2013-06-14 12:37:36 UTC) #1
Wladimir Palant
I guess that this patch does the job - but I would prefer to see ...
June 14, 2013, 12:45 p.m. (2013-06-14 12:45:22 UTC) #2
Felix Dahlke
LGTM, but I'd prefer an RAII wrapper for critical section as well.
June 17, 2013, 9:21 a.m. (2013-06-17 09:21:28 UTC) #3
Oleksandr
June 17, 2013, 11:12 a.m. (2013-06-17 11:12:25 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/11012013/diff/5001/src/engine/Debug.cpp File src/engine/Debug.cpp (right): http://codereview.adblockplus.org/11012013/diff/5001/src/engine/Debug.cpp#newcode12 src/engine/Debug.cpp:12: CriticalSection debugLock; IMHO this should be kept inside the ...
June 17, 2013, 12:57 p.m. (2013-06-17 12:57:24 UTC) #5
Oleksandr
June 25, 2013, 11:57 a.m. (2013-06-25 11:57:56 UTC) #6
Wladimir Palant
LGTM
June 25, 2013, 12:20 p.m. (2013-06-25 12:20:24 UTC) #7
Felix Dahlke
June 25, 2013, 12:22 p.m. (2013-06-25 12:22:16 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld