src/engine/Debug.cpp - Issue 11012013: Hanging resolved (critical sections unlocking)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/engine/Debug.cpp

Issue 11012013: Hanging resolved (critical sections unlocking) (Closed)

Left Patch Set: Using CriticalSection class instead Created June 17, 2013, 10:03 a.m.

Right Patch Set: Comments addressed Created June 25, 2013, 11:56 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #include <fstream>	1 #include <fstream>

2 #include <stdio.h>	2 #include <stdio.h>

3 #include <sstream>	3 #include <sstream>

4 #include <Windows.h>	4 #include <Windows.h>

5	5

6 #include "../shared/Utils.h"	6 #include "../shared/Utils.h"

	7 #include "../shared/CriticalSection.h"

7	8

8 #include "Debug.h"	9 #include "Debug.h"

9	10

10 #ifdef _DEBUG	11 #ifdef _DEBUG

11	12

12 CriticalSection debugLock;	13 namespace
Wladimir Palant 2013/06/17 12:57:24 IMHO this should be kept inside the anonymous name IMHO this should be kept inside the anonymous namespace.
13	14 {

	15 CriticalSection debugLock;

	16 };

14 void Debug(const std::string& text)	17 void Debug(const std::string& text)

15 {	18 {

16 SYSTEMTIME st;	19 SYSTEMTIME st;

17 ::GetSystemTime(&st);	20 ::GetSystemTime(&st);

18	21

19 char timeBuf[14];	22 char timeBuf[14];

20 _snprintf_s(timeBuf, _TRUNCATE, "%02i:%02i:%02i.%03i", st.wHour, st.wMinute, s t.wSecond, st.wMilliseconds);	23 _snprintf_s(timeBuf, _TRUNCATE, "%02i:%02i:%02i.%03i", st.wHour, st.wMinute, s t.wSecond, st.wMilliseconds);

21	24

22 std::wstring filePath = GetAppDataPath() + L"\\debug_engine.txt";	25 std::wstring filePath = GetAppDataPath() + L"\\debug_engine.txt";

23	26

(...skipping 12 matching lines...) Expand all Loading...
36	39

37 void DebugException(const std::exception& exception)	40 void DebugException(const std::exception& exception)

38 {	41 {

39 Debug(std::string("An exception occurred: ") + exception.what());	42 Debug(std::string("An exception occurred: ") + exception.what());

40 }	43 }

41 #else	44 #else

42 void Debug(const std::string& text) {}	45 void Debug(const std::string& text) {}

43 void DebugLastError(const std::string& message) {}	46 void DebugLastError(const std::string& message) {}

44 void DebugException(const std::exception& exception) {}	47 void DebugException(const std::exception& exception) {}

45 #endif // _DEBUG	48 #endif // _DEBUG

LEFT	RIGHT