Hanging resolved (critical sections unlocking)

src/shared/Utils.h

 #ifndef UTILS_H
 #define UTILS_H
 
 #include <algorithm>
 #include <locale>
 #include <functional>
 #include <string>
 
 
 bool IsWindowsVistaOrLater();
 
 std::string ToUtf8String(const std::wstring& str);
 std::wstring ToUtf16String(const std::string& str);
 std::wstring GetDllDir();
 std::wstring GetAppDataPath();
 
 template<class T>
 T TrimString(T text)
 {
   // Via http://stackoverflow.com/questions/216823/whats-the-best-way-to-trim-stdstring
   T trimmed(text);
   std::function<bool(T::value_type)> isspace = std::bind(&std::isspace<T::value_type>, std::placeholders::_1, std::locale::classic());
   trimmed.erase(trimmed.begin(), std::find_if(trimmed.begin(), trimmed.end(), std::not1(isspace)));
   trimmed.erase(std::find_if(trimmed.rbegin(), trimmed.rend(), std::not1(isspace)).base(), trimmed.end());
   return trimmed;
 }
 
-namespace

[Wladimir Palant, 2013/06/17 12:57:24]

If it's a public class then it shouldn't be declared in the anonymous namespace.
Also, it would probably be better to have a separate CriticalSection.h for it.

-{
-  class CriticalSection
-  {
-  public:
-    CriticalSection()
-    {
-      InitializeCriticalSection(&section);
-    }
-
-    ~CriticalSection()
-    {
-      DeleteCriticalSection(&section);
-    }
-
-    class Lock
-    {
-    public:
-      Lock(CriticalSection& cs)
-          : section(&cs.section)
-      {
-        EnterCriticalSection(section);
-      }
-
-      ~Lock()
-      {
-        LeaveCriticalSection(section);
-      }
-    private:
-      LPCRITICAL_SECTION section;
-      Lock(const Lock&);
-      Lock& operator=(const Lock&);
-    };
-  private:
-    CRITICAL_SECTION section;
-    CriticalSection(const CriticalSection&);
-    CriticalSection& operator=(const CriticalSection&);
-  };
-}
 #endif // UTILS_H