Unified Diff: src/plugin/PluginDebug.cpp
Issue 11013110:
Cleanup (Closed)
Patch Set: More refactoring. Removing main thread, tab counting. Implementing SetPref and GetPref. Addressing …
Created July 9, 2013, 12:59 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« src/plugin/PluginClass.cpp ('K')
|
« src/plugin/PluginClientBase.cpp ('k')
|
src/plugin/PluginSettings.h » ('j')
|
src/plugin/PluginSettings.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/plugin/PluginDebug.cpp |
| =================================================================== |
| --- a/src/plugin/PluginDebug.cpp |
| +++ b/src/plugin/PluginDebug.cpp |
| @@ -44,22 +44,6 @@ |
| bool isWorkingThread = settings->IsWorkingThread(dwThreadId); |
| CString processor; |
|
Wladimir Palant
2013/07/11 12:53:10
Aren't you leaving that variable uninitialized? Ho
Oleksandr
2013/07/22 00:48:16
Process ID isn't really a reliable identifier here
|
| - if (settings->IsMainProcess(dwProcessId) && settings->IsMainThread(dwThreadId)) |
| - { |
| - processor = L"main_thread"; |
| - } |
| - else if (settings->IsMainProcess(dwProcessId) && settings->IsMainUiThread(dwThreadId)) |
| - { |
| - processor = L"main_ui"; |
| - } |
| - else if (isWorkingThread) |
| - { |
| - processor = L"tab" + settings->GetTabNumber() + L"_thread"; |
| - } |
| - else |
| - { |
| - processor = L"tab" + settings->GetTabNumber() + L"_ui"; |
| - } |
| #else |
| if (dwProcessId == 0) |
| { |
« src/plugin/PluginClass.cpp ('K')
|
« src/plugin/PluginClientBase.cpp ('k')
|
src/plugin/PluginSettings.h » ('j')
|
src/plugin/PluginSettings.h » ('J')
