Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/ui.js

Issue 11015083: Merge labels and access keys into one string in locales (Closed)
Left Patch Set: Created July 3, 2013, 9:11 a.m.
Right Patch Set: Created July 9, 2013, 12:03 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2013 Eyeo GmbH 3 * Copyright (C) 2006-2013 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 let element = doc.getElementById(id); 79 let element = doc.getElementById(id);
80 if (element) 80 if (element)
81 element.value = checked; 81 element.value = checked;
82 } 82 }
83 function addCommandHandler(id, handler) 83 function addCommandHandler(id, handler)
84 { 84 {
85 let element = doc.getElementById(id); 85 let element = doc.getElementById(id);
86 if (element) 86 if (element)
87 element.addEventListener("command", handler, false); 87 element.addEventListener("command", handler, false);
88 } 88 }
89
90 Utils.splitAllLabels(doc);
Wladimir Palant 2013/07/09 12:10:59 I forgot about the labels on the settings page tha
89 91
90 addCommandHandler("adblockplus-filters", UI.openFiltersDialog.bind(UI)); 92 addCommandHandler("adblockplus-filters", UI.openFiltersDialog.bind(UI));
91 93
92 let {Sync} = require("sync"); 94 let {Sync} = require("sync");
93 let syncEngine = Sync.getEngine(); 95 let syncEngine = Sync.getEngine();
94 hideElement("adblockplus-sync", !syncEngine); 96 hideElement("adblockplus-sync", !syncEngine);
95 97
96 let {defaultToolbarPosition, statusbarPosition} = require("appSupport"); 98 let {defaultToolbarPosition, statusbarPosition} = require("appSupport");
97 let hasToolbar = defaultToolbarPosition && !defaultToolbarPosition.isAddonBa r; 99 let hasToolbar = defaultToolbarPosition && !defaultToolbarPosition.isAddonBa r;
98 let hasAddonBar = defaultToolbarPosition && defaultToolbarPosition.isAddonBa r; 100 let hasAddonBar = defaultToolbarPosition && defaultToolbarPosition.isAddonBa r;
(...skipping 1832 matching lines...) Expand 10 before | Expand all | Expand 10 after
1931 ["abp-command-contribute", "command", UI.openContributePage.bind(UI)], 1933 ["abp-command-contribute", "command", UI.openContributePage.bind(UI)],
1932 ["abp-command-contribute-hide", "command", UI.hideContributeButton.bind(UI)] 1934 ["abp-command-contribute-hide", "command", UI.hideContributeButton.bind(UI)]
1933 ]; 1935 ];
1934 1936
1935 onShutdown.add(function() 1937 onShutdown.add(function()
1936 { 1938 {
1937 for (let window in UI.applicationWindows) 1939 for (let window in UI.applicationWindows)
1938 if (UI.isBottombarOpen(window)) 1940 if (UI.isBottombarOpen(window))
1939 UI.toggleBottombar(window); 1941 UI.toggleBottombar(window);
1940 }); 1942 });
LEFTRIGHT

Powered by Google App Engine
This is Rietveld