Merge labels and access keys into one string in locales

I`ve only included the en-US changes here, other locales have been changed as well of course. Everything seems to work fine with exception of the Backup&Restore button in Filter Preferences - <button type=menu> doesn`t seem to react to access key changes.

[Felix Dahlke, 2013-07-03 15:20:47]

I'm wondering if it wouldn't be cleaner to split the strings into labels and
accesskeys first, instead of doing that in the DOMContentLoaded listener. It is
a detail of our translation strings after all, while the accesskey attribute is
an XUL feature we're now using in a slightly confusing way.

But it's not really bad the way it is now, so LGTM.

http://codereview.adblockplus.org/11015083/diff/1/chrome/content/ui/sendRepor...
File chrome/content/ui/sendReport.js (right):

http://codereview.adblockplus.org/11015083/diff/1/chrome/content/ui/sendRepor...
chrome/content/ui/sendReport.js:1217: delete nextButton._origLabel;
Seems like an unrelated change, what's wrong with removeAttribute?

[Wladimir Palant, 2013-07-09 12:10:58]

On 2013/07/03 15:20:47, Felix H. Dahlke wrote:
> I'm wondering if it wouldn't be cleaner to split the strings into labels and
> accesskeys first, instead of doing that in the DOMContentLoaded listener.

When would that be - when packaging the extension or when importing strings from
Crowdin? Both would introduce a conversion that's not obvious from the source
code and would require the developers to dig into build tools source, that's why
I decided against it. Besides, doing the splitting at runtime has the additional
advantage of reducing the package size by 50 kB.

http://codereview.adblockplus.org/11015083/diff/1/chrome/content/ui/sendRepor...
File chrome/content/ui/sendReport.js (right):

http://codereview.adblockplus.org/11015083/diff/1/chrome/content/ui/sendRepor...
chrome/content/ui/sendReport.js:1217: delete nextButton._origLabel;
On 2013/07/03 15:20:47, Felix H. Dahlke wrote:
> Seems like an unrelated change, what's wrong with removeAttribute?

Yes, this is somewhat unrelated. However, using an HTML attribute when all we
need is an expando property is an overkill.

I originally forgot to adapt the hasAttribute() check, this has been fixed now.

http://codereview.adblockplus.org/11015083/diff/5001/lib/ui.js
File lib/ui.js (right):

http://codereview.adblockplus.org/11015083/diff/5001/lib/ui.js#newcode90
lib/ui.js:90: Utils.splitAllLabels(doc);
I forgot about the labels on the settings page that is displayed by the Add-ons
Manager, this fixes it.

http://codereview.adblockplus.org/11015083/diff/5001/lib/utils.js
File lib/utils.js (right):

http://codereview.adblockplus.org/11015083/diff/5001/lib/utils.js#newcode507
lib/utils.js:507: if (accesskey != "")
The added checks here aren't strictly necessary but not changing attributes
unless it's necessary is slightly cleaner.

[Felix Dahlke, 2013-07-09 12:20:39]

LGTM