Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11027049: Removed typo correction feature (Closed)

Created:
June 27, 2013, 4:35 p.m. by Thomas Greiner
Modified:
June 28, 2013, 9:05 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Removed typo correction feature

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -86 lines) Patch
M chrome/content/ui/fennecSettings.xul View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/content/ui/filters.js View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/content/ui/filters.xul View 3 chunks +0 lines, -18 lines 0 comments Download
M chrome/content/ui/firstRun.html View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/content/ui/firstRun.js View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/locale/en-US/filters.dtd View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/locale/en-US/firstRun.properties View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/locale/en-US/global.properties View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/skin/firstRun.css View 1 chunk +0 lines, -5 lines 0 comments Download
M defaults/prefs.js View 1 chunk +0 lines, -4 lines 0 comments Download
M lib/main.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
Removed all files and modifications that were added with the typo correction feature. Also removed ...
June 27, 2013, 4:46 p.m. (2013-06-27 16:46:09 UTC) #1
Wladimir Palant
LGTM assuming that removed files didn't show up in the review - locale/*/typo.properties, content/ui/typoSettings.js, defaults/typoRules.json ...
June 27, 2013, 5:04 p.m. (2013-06-27 17:04:10 UTC) #2
Thomas Greiner
FYI: I removed the following files: - chrome/content/ui/typoSettings.js - chrome/locale/en-US/typo.properties - chrome/skin/features/typo.png - chrome/skin/icon16.png - ...
June 28, 2013, 8:39 a.m. (2013-06-28 08:39:28 UTC) #3
Wladimir Palant
June 28, 2013, 9:03 a.m. (2013-06-28 09:03:36 UTC) #4
Yes, that's fine.

Powered by Google App Engine
This is Rietveld