Issue 11039026: Use a subprocess wrapper that will throw if a command returns a non-zero result code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11039026: Use a subprocess wrapper that will throw if a command returns a non-zero result code (Closed)

Created:
July 4, 2013, 7:18 a.m. by Wladimir Palant

Modified:
July 4, 2013, 8:54 a.m.

Reviewers:
Sebastian Noack, Felix Dahlke

Visibility:
Public.

Use a subprocess wrapper that will throw if a command returns a non-zero result code

Created: July 4, 2013, 7:42 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	abp_rewrite.py	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
	M	autotest.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4

Wladimir Palant

Turns out that wrapper is already there, it's called subprocess.check_output() :). New patch is using ...

July 4, 2013, 7:31 a.m. (2013-07-04 07:31:50 UTC) #2

LGTM