Unified Diff: autotest.py
Issue 11039026:
Use a subprocess wrapper that will throw if a command returns a non-zero result code (Closed)
Patch Set: Same thing without a custom wrapper
Created July 4, 2013, 7:30 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« abp_rewrite.py ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: autotest.py |
| =================================================================== |
| --- a/autotest.py |
| +++ b/autotest.py |
| @@ -30,17 +30,17 @@ def run_tests(): |
| elif match and match.group(1).lower() == 'arguments': |
| arguments = match.group(2).split(' ') |
| handle.close() |
| if arguments == None: |
| continue |
| command = [application, os.path.join(baseDir, 'jshydra.js'), file] + arguments |
| - out = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, env=env).communicate()[0].replace('\r', '') |
| + out = subprocess.check_output(command, env=env).replace('\r', '') |
| expected = open(file + '.expected', 'r').read().replace('\r', '') |
| if out == expected: |
| print '%s passed' % name |
| else: |
| print '%s failed! Log:' % name |
| for line in difflib.unified_diff(expected.split('\n'), out.split('\n'), fromfile=file + '.expected', tofile=file + '.output'): |
| print line |
« no previous file with comments
|
« abp_rewrite.py ('k')
|
no next file »
|
no next file with comments »
