Unified Diff: abp_rewrite.py
Issue 11039026:
Use a subprocess wrapper that will throw if a command returns a non-zero result code (Closed)
Patch Set: Restored stderr redirection in autotest
Created July 4, 2013, 7:42 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
autotest.py » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: abp_rewrite.py |
| =================================================================== |
| --- a/abp_rewrite.py |
| +++ b/abp_rewrite.py |
| @@ -15,18 +15,16 @@ def doRewrite(files, args): |
| } |
| baseDir = os.path.dirname(utils.__file__) |
| command = [ |
| application, os.path.join(baseDir, 'jshydra.js'), |
| os.path.join(baseDir, 'scripts', 'abprewrite.js'), |
| '--arg', ' '.join(args) |
| ] + files |
| - result, dummy = subprocess.Popen(command, stdout=subprocess.PIPE, env=env).communicate() |
| - result = result.replace('\r', '') |
| - return result |
| + return subprocess.check_output(command, env=env).replace('\r', '') |
| if __name__ == '__main__': |
| try: |
| scriptArgsStart = sys.argv.index('--arg') |
| except ValueError: |
| scriptArgsStart = len(sys.argv) |
| print doRewrite(sys.argv[1:scriptArgsStart], sys.argv[scriptArgsStart + 1:]) |
« no previous file with comments
|
« no previous file
|
autotest.py » ('j')
|
no next file with comments »
