Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11075001: Added fallback to first-run page for when social media buttons are blocked by filters (Closed)

Created:
June 27, 2013, 10:18 a.m. by Thomas Greiner
Modified:
July 8, 2013, 10 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

A workaround for the case that our social media widgets were not shown when the "Remove Social Media Buttons" feature was enabled. In that case clicking on the button will open our social media page rather than opening the share popup.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M chrome/content/ui/firstRun.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/content/ui/firstRun.js View 2 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 2
Thomas Greiner
I'm only checking for the Twitter resource because if that one's blocked it's extremely unlikely ...
June 27, 2013, 10:23 a.m. (2013-06-27 10:23:07 UTC) #1
Wladimir Palant
July 8, 2013, 9:38 a.m. (2013-07-08 09:38:31 UTC) #2
LGTM - please check in as is, I'll slightly improve the fallback then.

Powered by Google App Engine
This is Rietveld