Issue 11094018: Use i18n.js from adblockplus to restrict HTML tag usage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11094018: Use i18n.js from adblockplus to restrict HTML tag usage (Closed)

Created:
July 16, 2013, 9:28 a.m. by Thomas Greiner

Modified:
July 16, 2013, 12:19 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

Applied changes from https://hg.adblockplus.org/adblockplus/rev/6f7fa0bed1b2 to Adblock Plus for Chrome.

Patch Set 1 #

Total comments: 6

Created: July 16, 2013, 9:28 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -20 lines)			Patch
M	_locales/en_US/messages.json	View	2 chunks	+2 lines, -15 lines	1 comment	Download
M	metadata.chrome	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	options.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	options.js	View	4 chunks	+27 lines, -2 lines	1 comment	Download
M	popup.html	View	1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Thomas Greiner

http://codereview.adblockplus.org/11094018/diff/1/_locales/en_US/messages.json File _locales/en_US/messages.json (left): http://codereview.adblockplus.org/11094018/diff/1/_locales/en_US/messages.json#oldcode101 _locales/en_US/messages.json:101: "message": "New filters added; see <a id='options_url' target='_blank'>Options</a> to ...

July 16, 2013, 9:36 a.m. (2013-07-16 09:36:03 UTC) #1

Wladimir Palant

July 16, 2013, 10:39 a.m. (2013-07-16 10:39:27 UTC) #2

LGTM with the links generalized.

http://codereview.adblockplus.org/11094018/diff/1/options.js
File options.js (right):

http://codereview.adblockplus.org/11094018/diff/1/options.js#newcode47
options.js:47: setLinks("filter-must-follow-syntax",
"https://adblockplus.org/en/filters");
On 2013/07/16 09:36:04, Thomas Greiner wrote:
> If you want me to use Utils.getDocLink("filters") please set it up first or
tell
> me the link ID if it already exists.

The link ID indeed exists already - "filterdoc".

http://codereview.adblockplus.org/11094018/diff/1/options.js#newcode48
options.js:48: setLinks("found-a-bug",
"https://adblockplus.org/forum/viewforum.php?f=10");
On 2013/07/16 09:36:04, Thomas Greiner wrote:
> If you want me to use Utils.getDocLink("report_bug") please set it up first or
> tell me the link ID if it already exists.

Added "chrome_support" and "opera_support" links - link needs to be different
depending on require("info").application.

Expand All Messages | Collapse All Messages