Notifications: implemented better target checks - unit tests

chrome/content/tests/notification.js

 (function()
 {
   let testRunner = null;
   let server = null;
   let randomResult = 0.5;
 
   let originalInfo;
   let info = require("info");
 
   module("Notification handling",
@@ skipping 190 matching lines @@
 
       Prefs.notificationdata = {};
       registerHandler([information]);
       testRunner.runScheduledTasks(1);
 
       let expected = (result ? information : null);
       deepEqual(Notification.getNextToShow(), expected, "Selected notification for " + JSON.stringify(information.targets));
       deepEqual(Notification.getNextToShow(), null, "No notification on second call");
     }
 
-    function allPairs(array)
+    function pairs(array)
     {
-      var pairs = [];
-      for (var i = 0; i < array.length - 1; i++)
-        for (var j = i + 1; j < array.length; j++)
-          pairs.push([array[i], array[j]]);
-      return pairs;
+      for each (let element1 in array)
+        for each (let element2 in array)
+          yield [element1, element2];
     }
-    for each (let [[propName1, value1, result1], [propName2, value2, result2]] in allPairs(targets))
+    for (let [[propName1, value1, result1], [propName2, value2, result2]] in pairs(targets))
     {
       let targetInfo1 = {};
       targetInfo1[propName1] = value1;
       let targetInfo2 = {};
       targetInfo2[propName2] = value2;
 
       let information = fixConstructors({
         id: 1,
         severity: "information",
         message: {"en-US": "Information"},
@@ skipping 50 matching lines @@
     equal(texts.message, "fr");
   });
 
   test("Missing translation", function()
   {
     let notification = {message: {"en-US": "en-US"}};
     let texts = Notification.getLocalizedTexts(notification, "fr");
     equal(texts.message, "en-US");
   });
 })();