Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11127037: Notifications: implemented better target checks - unit tests (Closed)

Created:
July 19, 2013, 2:42 p.m. by Wladimir Palant
Modified:
July 25, 2013, 11:23 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Notifications: implemented better target checks - unit tests

Patch Set 1 #

Total comments: 2

Patch Set 2 : Better pair generation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/content/tests/notification.js View 1 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
July 19, 2013, 2:42 p.m. (2013-07-19 14:42:33 UTC) #1
Felix Dahlke
LGTM with a nit http://codereview.adblockplus.org/11127037/diff/1/chrome/content/tests/notification.js File chrome/content/tests/notification.js (right): http://codereview.adblockplus.org/11127037/diff/1/chrome/content/tests/notification.js#newcode213 chrome/content/tests/notification.js:213: var pairs = []; Why ...
July 25, 2013, 10:22 a.m. (2013-07-25 10:22:04 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/11127037/diff/1/chrome/content/tests/notification.js File chrome/content/tests/notification.js (right): http://codereview.adblockplus.org/11127037/diff/1/chrome/content/tests/notification.js#newcode213 chrome/content/tests/notification.js:213: var pairs = []; On 2013/07/25 10:22:04, Felix H. ...
July 25, 2013, 10:58 a.m. (2013-07-25 10:58:07 UTC) #3
Wladimir Palant
Never mind, I improved the pair generation function (use the View link, not comparison to ...
July 25, 2013, 11:13 a.m. (2013-07-25 11:13:30 UTC) #4
Felix Dahlke
July 25, 2013, 11:15 a.m. (2013-07-25 11:15:27 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld