Add tests for the Notification module

Add tests for the Notification module

[Wladimir Palant, 2013-07-19 08:18:29]

All other issues have been addressed in my changes already so it is up to you to
review now.

http://codereview.adblockplus.org/11144022/diff/3001/chrome/content/tests/not...
File chrome/content/tests/notification.js (right):

http://codereview.adblockplus.org/11144022/diff/3001/chrome/content/tests/not...
chrome/content/tests/notification.js:25: test("Single notification", 1,
function()
I would rather not specify the number of checks explicitly - it makes changing
the tests more complicated than necessary and I don't think that this provides
actual value.

[Felix Dahlke, 2013-07-19 14:30:40]

http://codereview.adblockplus.org/11144022/diff/3001/chrome/content/tests/not...
File chrome/content/tests/notification.js (right):

http://codereview.adblockplus.org/11144022/diff/3001/chrome/content/tests/not...
chrome/content/tests/notification.js:25: test("Single notification", 1,
function()
On 2013/07/19 08:18:29, Wladimir Palant wrote:
> I would rather not specify the number of checks explicitly - it makes changing
> the tests more complicated than necessary and I don't think that this provides
> actual value.

Agreed, that was a misconception on my side. You addressed this by now, so Done.

http://codereview.adblockplus.org/11144022/diff/6001/chrome/content/tests/not...
File chrome/content/tests/notification.js (right):

http://codereview.adblockplus.org/11144022/diff/6001/chrome/content/tests/not...
chrome/content/tests/notification.js:39: randomResult = 0.5;
This seems redundant, looks like randomResult is always 0.5 anyway.

http://codereview.adblockplus.org/11144022/diff/6001/chrome/content/tests/syn...
File chrome/content/tests/synchronizer.js (right):

http://codereview.adblockplus.org/11144022/diff/6001/chrome/content/tests/syn...
chrome/content/tests/synchronizer.js:27: randomResult = 0.5;
As in notification.js - it looks like this is always 0.5 to begin with.

[Wladimir Palant, 2013-07-19 14:58:49]

http://codereview.adblockplus.org/11144022/diff/6001/chrome/content/tests/not...
File chrome/content/tests/notification.js (right):

http://codereview.adblockplus.org/11144022/diff/6001/chrome/content/tests/not...
chrome/content/tests/notification.js:39: randomResult = 0.5;
On 2013/07/19 14:30:41, Felix H. Dahlke wrote:
> This seems redundant, looks like randomResult is always 0.5 anyway.

Actually, the point here is to reset randomResult for each single test, no
matter whether its value is changed. I actually mean to add a test that will
change randomResult to test that the download interval is correct.

http://codereview.adblockplus.org/11144022/diff/6001/chrome/content/tests/syn...
File chrome/content/tests/synchronizer.js (right):

http://codereview.adblockplus.org/11144022/diff/6001/chrome/content/tests/syn...
chrome/content/tests/synchronizer.js:27: randomResult = 0.5;
On 2013/07/19 14:30:41, Felix H. Dahlke wrote:
> As in notification.js - it looks like this is always 0.5 to begin with.

Not really, one of the tests changes it - and this makes sure that each test can
rely on its value being 0.5 unless it changes the value explicitly.

[Felix Dahlke, 2013-07-19 14:59:36]

On 2013/07/19 14:58:49, Wladimir Palant wrote:
>
http://codereview.adblockplus.org/11144022/diff/6001/chrome/content/tests/not...
> File chrome/content/tests/notification.js (right):
> 
>
http://codereview.adblockplus.org/11144022/diff/6001/chrome/content/tests/not...
> chrome/content/tests/notification.js:39: randomResult = 0.5;
> On 2013/07/19 14:30:41, Felix H. Dahlke wrote:
> > This seems redundant, looks like randomResult is always 0.5 anyway.
> 
> Actually, the point here is to reset randomResult for each single test, no
> matter whether its value is changed. I actually mean to add a test that will
> change randomResult to test that the download interval is correct.
> 
>
http://codereview.adblockplus.org/11144022/diff/6001/chrome/content/tests/syn...
> File chrome/content/tests/synchronizer.js (right):
> 
>
http://codereview.adblockplus.org/11144022/diff/6001/chrome/content/tests/syn...
> chrome/content/tests/synchronizer.js:27: randomResult = 0.5;
> On 2013/07/19 14:30:41, Felix H. Dahlke wrote:
> > As in notification.js - it looks like this is always 0.5 to begin with.
> 
> Not really, one of the tests changes it - and this makes sure that each test
can
> rely on its value being 0.5 unless it changes the value explicitly.

Oh, didn't notice. Well, LGTM then :)