Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 11166107: Set up notification server (Closed)

Created:
July 22, 2013, 10:11 a.m. by Wladimir Palant
Modified:
July 23, 2013, 8:23 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Set up notification server

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -2 lines) Patch
M Vagrantfile View 1 chunk +1 line, -0 lines 0 comments Download
M manifests/monitoringserver.pp View 1 chunk +2 lines, -1 line 0 comments Download
M manifests/nodes.pp View 1 chunk +1 line, -0 lines 0 comments Download
A manifests/notificationserver.pp View 1 chunk +7 lines, -0 lines 0 comments Download
M manifests/vagrant.pp View 1 chunk +3 lines, -0 lines 0 comments Download
M modules/nginx/manifests/init.pp View 1 chunk +1 line, -1 line 0 comments Download
A modules/notificationserver/files/logrotate View 1 chunk +11 lines, -0 lines 0 comments Download
A modules/notificationserver/files/notification.json View 1 chunk +1 line, -0 lines 0 comments Download
A modules/notificationserver/files/notification.adblockplus.org View 1 chunk +31 lines, -0 lines 0 comments Download
A modules/notificationserver/manifests/init.pp View 1 chunk +63 lines, -0 lines 2 comments Download

Messages

Total messages: 4
Wladimir Palant
July 22, 2013, 10:11 a.m. (2013-07-22 10:11:08 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/11166107/diff/1/modules/notificationserver/manifests/init.pp File modules/notificationserver/manifests/init.pp (right): http://codereview.adblockplus.org/11166107/diff/1/modules/notificationserver/manifests/init.pp#newcode22 modules/notificationserver/manifests/init.pp:22: file {'/var/www/notification/notification.json': We should set replace => "no" here, ...
July 22, 2013, 3:19 p.m. (2013-07-22 15:19:30 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/11166107/diff/1/modules/notificationserver/manifests/init.pp File modules/notificationserver/manifests/init.pp (right): http://codereview.adblockplus.org/11166107/diff/1/modules/notificationserver/manifests/init.pp#newcode22 modules/notificationserver/manifests/init.pp:22: file {'/var/www/notification/notification.json': On 2013/07/22 15:19:30, Felix H. Dahlke wrote: ...
July 23, 2013, 7:27 a.m. (2013-07-23 07:27:53 UTC) #3
Felix Dahlke
July 23, 2013, 7:42 a.m. (2013-07-23 07:42:05 UTC) #4 
On 2013/07/23 07:27:53, Wladimir Palant wrote:
>
http://codereview.adblockplus.org/11166107/diff/1/modules/notificationserver/...
> File modules/notificationserver/manifests/init.pp (right):
> 
>
http://codereview.adblockplus.org/11166107/diff/1/modules/notificationserver/...
> modules/notificationserver/manifests/init.pp:22: file
> {'/var/www/notification/notification.json':
> On 2013/07/22 15:19:30, Felix H. Dahlke wrote:
> > We should set replace => "no" here, otherwise our changes will be
overwritten
> > whenever we run Puppet agent.
> 
> Replacing the file was actually the idea - we can use Puppet to deploy it for
> now. Once that file is generated automatically Puppet configuration should be
> changed to no longer create it of course.

Oh, thought we were going to change it right on the system, but Puppet is
probably better, yeah. LGTM

Powered by Google App Engine
This is Rietveld