Fix the crash. IInternetBindInfo BINDSTRING_XDR_ORIGIN bug workaround.

src/plugin/PluginWbPassThrough.cpp

Index: src/plugin/PluginWbPassThrough.cpp
===================================================================
--- a/src/plugin/PluginWbPassThrough.cpp
+++ b/src/plugin/PluginWbPassThrough.cpp
@@ -142,8 +142,13 @@
     {
       mimeType.SetString(mime);
     }
+    LPOLESTR bindToObject = 0;
+    hr = pOIBindInfo->GetBindString(BINDSTRING_FLAG_BIND_TO_OBJECT, &bindToObject, 1, &resLen);
     LPOLESTR domainRetrieved = 0;
-    hr = pOIBindInfo->GetBindString(BINDSTRING_XDR_ORIGIN, &domainRetrieved, 1, &resLen);
+    if (resLen == 0 || wcscmp(bindToObject, L"FALSE") == 0)
+    {   
+      hr = pOIBindInfo->GetBindString(BINDSTRING_XDR_ORIGIN, &domainRetrieved, 1, &resLen);
+    }
     if ((hr == S_OK) && domainRetrieved && (resLen > 0))

[Felix Dahlke, 2013/08/05 14:28:05]

Shouldn't this be moved into the if as well? What happens if resLen is not null
but bindToObject was not FALSE? We'll do something with domainRetrieved which is
0.

[Oleksandr, 2013/08/08 14:03:20]

I might be missing something but we will not do anything with the
domainRetrieved, because it's 0 in this if. So the end result would be an empty
string boundDomain.
On 2013/08/05 14:28:05, Felix H. Dahlke wrote:

[Felix Dahlke, 2013/08/08 14:13:55]

Right, there's a check for domainRetrieved there, so it'll work as intended.

I still think it's a bit confusing this way, we should move this code into the
if above, it logically runs only under that condition.

[Oleksandr, 2013/08/08 14:22:21]

Agreed. 
On 2013/08/08 14:13:55, Felix H. Dahlke wrote:

     {
       boundDomain.SetString(domainRetrieved);