Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23)

Issue 11180001: Automatically generate info pseudo-module for Chromium-based applications (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by Wladimir Palant
Modified:
6 years, 7 months ago
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Automatically generate info pseudo-module for Chromium-based applications

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M chromeDevenvPoller__.js.tmpl View 1 chunk +17 lines, -0 lines 0 comments Download
A chromeInfo.js.tmpl View 1 chunk +44 lines, -0 lines 2 comments Download
M packagerChrome.py View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
6 years, 7 months ago (2013-07-22 13:26:33 UTC) #1
Thomas Greiner
LGTM Side note (in case you're not aware of it): This code changes values for ...
6 years, 7 months ago (2013-07-23 13:23:37 UTC) #2
Wladimir Palant
On 2013/07/23 13:23:37, Thomas Greiner wrote: > Side note (in case you're not aware of ...
6 years, 7 months ago (2013-07-23 14:15:04 UTC) #3
Wladimir Palant
6 years, 7 months ago (2013-07-23 14:15:11 UTC) #4
http://codereview.adblockplus.org/11180001/diff/1/chromeInfo.js.tmpl
File chromeInfo.js.tmpl (right):

http://codereview.adblockplus.org/11180001/diff/1/chromeInfo.js.tmpl#newcode25
chromeInfo.js.tmpl:25: addonRoot: "",
On 2013/07/23 13:23:37, Thomas Greiner wrote:
> If you want to implement this you could use
> chrome.extension.getURL("/")
> or
> chrome.extension.getURL("")

I don't think I want this implemented - knowing the add-on root is only
necessary in Firefox, to generate some URLs. Chrome has
chrome.extension.getURL() for that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5