Automatically generate info pseudo-module for Chromium-based applications

Automatically generate info pseudo-module for Chromium-based applications

[Thomas Greiner, 2013-07-23 13:23:37]

LGTM

Side note (in case you're not aware of it):
This code changes values for addonName (from "Adblock Plus" to
"adblockpluschrome"/"adblockplusopera") and addonVersion (from "2.1" to "1.5").
Doesn't seem to be used anywhere yet so it shouldn't be a problem.

http://codereview.adblockplus.org/11180001/diff/1/chromeInfo.js.tmpl
File chromeInfo.js.tmpl (right):

http://codereview.adblockplus.org/11180001/diff/1/chromeInfo.js.tmpl#newcode25
chromeInfo.js.tmpl:25: addonRoot: "",
If you want to implement this you could use
chrome.extension.getURL("/")
or
chrome.extension.getURL("")

[Wladimir Palant, 2013-07-23 14:15:04]

On 2013/07/23 13:23:37, Thomas Greiner wrote:
> Side note (in case you're not aware of it):
> This code changes values for addonName (from "Adblock Plus" to
> "adblockpluschrome"/"adblockplusopera") and addonVersion (from "2.1" to
"1.5").
> Doesn't seem to be used anywhere yet so it shouldn't be a problem.

Yes, I am aware of that. addonName change actually fixes this value - we don't
want the actual name there but rather a codename that is sent to sever in some
requests (most importantly in the new downloader module).

addonVersion is used to check the required version number of a filter
subscription. The result is currently only displayed in Firefox but we'll have
to fix that eventually.

[Wladimir Palant, 2013-07-23 14:15:11]

http://codereview.adblockplus.org/11180001/diff/1/chromeInfo.js.tmpl
File chromeInfo.js.tmpl (right):

http://codereview.adblockplus.org/11180001/diff/1/chromeInfo.js.tmpl#newcode25
chromeInfo.js.tmpl:25: addonRoot: "",
On 2013/07/23 13:23:37, Thomas Greiner wrote:
> If you want to implement this you could use
> chrome.extension.getURL("/")
> or
> chrome.extension.getURL("")

I don't think I want this implemented - knowing the add-on root is only
necessary in Firefox, to generate some URLs. Chrome has
chrome.extension.getURL() for that.