Added script to generate notification.json for the emergencynotification mechanism

See https://hg.adblockplus.org/notifications/file/tip/1 for the file format this is meant to parse

[Sebastian Noack, 2013-07-27 14:06:04]

Also note that your naming scheme doesn't comply to PEP-8. The convention in
Python is to use underscores instead of camel-case for variable and function
names.

http://codereview.adblockplus.org/11275006/diff/1/sitescripts/management/bin/...
File sitescripts/management/bin/generateNotifications.py (right):

http://codereview.adblockplus.org/11275006/diff/1/sitescripts/management/bin/...
sitescripts/management/bin/generateNotifications.py:1: # coding: utf-8
There is no shebang and the file mode is 644 instead of 755. So you can'T call
this script directly.

http://codereview.adblockplus.org/11275006/diff/1/sitescripts/management/bin/...
sitescripts/management/bin/generateNotifications.py:4: # Copyright (C) 2006-2013
Eyeo GmbH
Since this is a new file, doesn't have the copyright line to include only the
current year?

http://codereview.adblockplus.org/11275006/diff/1/sitescripts/management/bin/...
sitescripts/management/bin/generateNotifications.py:89: tarFile =
tarfile.open(mode="r:", fileobj=StringIO(data))
You should close the tarfile object, also if you use an external fileobj. In
that case the tarfile module will leave the underlying fileobj open.

http://codereview.adblockplus.org/11275006/diff/1/sitescripts/management/bin/...
sitescripts/management/bin/generateNotifications.py:107: file.close()
Use try-finally block or even better the with statement, to make sure that close
is called in case of an exception.

[Wladimir Palant, 2013-07-29 14:09:44]

I fixed one of the noted issues, the others still need some discussion I think.

> Also note that your naming scheme doesn't comply to PEP-8. The convention in
> Python is to use underscores instead of camel-case for variable and function
> names.

Well, our non-compliance with PEP-8 is pretty notorious :)

So far we didn't really manage to decide whether it's more important to comply
with PEP-8 or to use a consistent naming scheme across all programming
languages.

http://codereview.adblockplus.org/11275006/diff/1/sitescripts/management/bin/...
File sitescripts/management/bin/generateNotifications.py (right):

http://codereview.adblockplus.org/11275006/diff/1/sitescripts/management/bin/...
sitescripts/management/bin/generateNotifications.py:1: # coding: utf-8
On 2013/07/27 14:06:05, sebastian wrote:
> There is no shebang and the file mode is 644 instead of 755. So you can'T call
> this script directly.

No, and we don't. It's being run with the following command line:

  python -m sitescripts.management.bin.generateNotifications

That's what we use for pretty much all of sitescripts.

http://codereview.adblockplus.org/11275006/diff/1/sitescripts/management/bin/...
sitescripts/management/bin/generateNotifications.py:4: # Copyright (C) 2006-2013
Eyeo GmbH
On 2013/07/27 14:06:05, sebastian wrote:
> Since this is a new file, doesn't have the copyright line to include only the
> current year?

I don't think that this approach would be anywhere close to maintainable. We
list the copyright year of the entire codebase, not single files - otherwise
each file would have a different license header. We changed license headers
multiple times in the past, that would be a huge mess if they are different
everywhere. Then again, I don't think we ever verified that our current approach
is correct...

http://codereview.adblockplus.org/11275006/diff/1/sitescripts/management/bin/...
sitescripts/management/bin/generateNotifications.py:107: file.close()
On 2013/07/27 14:06:05, sebastian wrote:
> Use try-finally block or even better the with statement, to make sure that
close
> is called in case of an exception.

I guess a with block would do better here - but is it really necessary? In case
of an exception that scripts will shut down and all handles will close anyway.

[Wladimir Palant, 2013-11-04 10:32:31]

I've made these scripts more compliant with PEP-8. However, I didn't feel
comfortable names of files or externally used functions in the same go. I've
also switched to using with statement instead of closing files explicitly. As to
the license boilerplate, I don't think that this review is the right place to
discuss it.

[Sebastian Noack, 2013-11-04 12:23:26]

LGTM