Issue 11292041: Use XMLHttpRequest.status instead of nsIHttpChannel.responseStatus(same value, better cross-browse…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11292041: Use XMLHttpRequest.status instead of nsIHttpChannel.responseStatus(same value, better cross-browse… (Closed)

Created:
July 29, 2013, 1:45 p.m. by Wladimir Palant

Modified:
Nov. 4, 2013, 11:46 a.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

Use XMLHttpRequest.status instead of nsIHttpChannel.responseStatus (same value, better cross-browse…

Patch Set 2 : Removed exception handling #

Created: July 31, 2013, 1:29 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	lib/downloader.js	View	1	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Thomas Greiner

LGTM with that change http://codereview.adblockplus.org/11292041/diff/1/lib/downloader.js File lib/downloader.js (right): http://codereview.adblockplus.org/11292041/diff/1/lib/downloader.js#newcode224 lib/downloader.js:224: responseStatus = request.status; You don't ...

July 31, 2013, 12:34 p.m. (2013-07-31 12:34:45 UTC) #2

Wladimir Palant

July 31, 2013, 1:31 p.m. (2013-07-31 13:31:26 UTC) #3

http://codereview.adblockplus.org/11292041/diff/1/lib/downloader.js
File lib/downloader.js (right):

http://codereview.adblockplus.org/11292041/diff/1/lib/downloader.js#newcode224
lib/downloader.js:224: responseStatus = request.status;
On 2013/07/31 12:34:45, Thomas Greiner wrote:
> You don't need a try/catch here anymore. You can simply do
> let responseStatus = request.status || -1;

I verified that the Mozilla implementation indeed doesn't throw exceptions, I
assume that other browsers don't do it either. Left out the || -1 part however -
if request.status is 0 then that's what we should report. -1 was a placeholder
for "cannot retrieve".

Expand All Messages | Collapse All Messages