lib/downloader.js - Issue 11292041: Use XMLHttpRequest.status instead of nsIHttpChannel.responseStatus(same value, better cross-browse…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/downloader.js

Issue 11292041: Use XMLHttpRequest.status instead of nsIHttpChannel.responseStatus(same value, better cross-browse… (Closed)

Patch Set: Removed exception handling Created July 31, 2013, 1:29 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/downloader.js

===================================================================

--- a/lib/downloader.js

+++ b/lib/downloader.js

@@ -213,21 +213,17 @@ Downloader.prototype =

let errorCallback = function errorCallback(error)

{

let channelStatus = -1;

try

{

channelStatus = request.channel.status;

} catch (e) {}

- let responseStatus = -1;

- try

- {

- responseStatus = request.status;

- } catch (e) {}

+ let responseStatus = request.status;

Cu.reportError("Adblock Plus: Downloading URL " + downloadable.url + " failed (" + error + ")\n" +

"Download address: " + downloadURL + "\n" +

"Channel status: " + channelStatus + "\n" +

"Server response: " + responseStatus);

if (this.onDownloadError)

{

« no previous file with comments | « no previous file | no next file » | no next file with comments »