Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11396001: Fixed broken links on options page (Closed)

Created:
Aug. 5, 2013, 3:07 p.m. by Sebastian Noack
Modified:
Aug. 14, 2013, 5:41 a.m.
CC:
cvervoorts_gmail.com
Visibility:
Public.

Description

Fixed broken links on options page

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -464 lines) Patch
M _locales/ar/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/bg/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/ca/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/cs/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/da/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/de/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/el/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/en_GB/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/es/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/es_419/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/et/messages.json View 2 chunks +2 lines, -7 lines 0 comments Download
M _locales/fa/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/fi/messages.json View 2 chunks +2 lines, -7 lines 0 comments Download
M _locales/fr/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/he/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/hr/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/hu/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/id/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/it/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/ja/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/ko/messages.json View 2 chunks +2 lines, -7 lines 0 comments Download
M _locales/lt/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/lv/messages.json View 2 chunks +2 lines, -7 lines 0 comments Download
M _locales/nl/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/pl/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/pt_BR/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/pt_PT/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/ro/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/ru/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/sk/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/sv/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/te/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/th/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/tr/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/uk/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/vi/messages.json View 2 chunks +2 lines, -7 lines 0 comments Download
M _locales/zh_CN/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download
M _locales/zh_TW/messages.json View 2 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 3
Sebastian Noack
Aug. 5, 2013, 3:16 p.m. (2013-08-05 15:16:42 UTC) #1
Felix Dahlke
LGTM, assuming the links work.
Aug. 5, 2013, 3:28 p.m. (2013-08-05 15:28:36 UTC) #2
Wladimir Palant
Aug. 14, 2013, 5:41 a.m. (2013-08-14 05:41:45 UTC) #3
I've just backed out that changeset - these locale files are autogenerated from
Crowdin data, they shouldn't be changed without updating Crowdin.

The problem here is that the English locale changed but a new translation round
on Crowdin wasn't started yet. Uploading a new master locale to Crowdin (just
did that) removes the outdated translations automatically. In some cases like
this one we might want to update the translations as well - but then we should
actually upload the new translations to Crowdin.

What I've done in detail:

* Backed out Sebastian's change
(https://hg.adblockplus.org/adblockpluschrome/rev/625fcdf6bdb2).
* Downloaded current translations from Crowdin
(https://hg.adblockplus.org/adblockpluschrome/rev/c99ec6c10afc).
* Updated the master locale on Crowdin.
* Reapplied Sebastian's patch while updating it for the Danish, Portuguese,
Tamil and Vietnamese locales
(https://hg.adblockplus.org/adblockpluschrome/rev/5316a364a5b5).
* Updated translations on Crowdin.
* Downloaded current translations from Crowdin again
(https://hg.adblockplus.org/adblockpluschrome/rev/46484ff8d16e) - this mostly
had the effect of removing a string that is no longer present in the master
locale.

Powered by Google App Engine
This is Rietveld