Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: modules/updateserver/files/logrotate
Issue
11439212
:
Add server21 as updateserver (Closed)
Patch Set: Addressed issues
Created Aug. 16, 2013, 2:07 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Addressed issues
Right:
Patch Set 1: None
Patch Set 2: Addressed issues
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Vagrantfile
manifests/monitoringserver.pp
manifests/nodes.pp
manifests/updateserver.pp
modules/updateserver/files/adblockplusie/update.json
modules/updateserver/files/logrotate
modules/updateserver/files/update.adblockplus.org
modules/updateserver/manifests/init.pp
View unified diff
|
Download patch
« no previous file with comments
|
« modules/updateserver/files/adblockplusie/update.json
('k') |
modules/updateserver/files/update.adblockplus.org »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
/var/log/nginx/access_log_update {
2
daily
3
rotate 30
4
compress
5
missingok
6
nodateext
7
sharedscripts
8
postrotate
9
[ ! -f /var/run/nginx.pid ] || kill -USR1 `cat /var/run/nginx.pid`
10
endscript
11
}
OLD
NEW
« no previous file with comments
|
« modules/updateserver/files/adblockplusie/update.json
('k') |
modules/updateserver/files/update.adblockplus.org »
('j') |
no next file with comments »
Edit Message
Issue 11439212: Add server21 as updateserver (Closed)
Created Aug. 16, 2013, 12:32 p.m. by Felix Dahlke
Modified Nov. 12, 2013, 10:13 a.m.
Reviewers: Wladimir Palant
Base URL:
Comments: 6
This is Rietveld